Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight incompatibility with Adafruit ecosystem #1114

Merged
merged 5 commits into from
Dec 30, 2022
Merged

Highlight incompatibility with Adafruit ecosystem #1114

merged 5 commits into from
Dec 30, 2022

Conversation

dglaude
Copy link
Contributor

@dglaude dglaude commented Dec 12, 2022

I try to manage expectation about this board and avoid short circuit or broken sensor. 1) I almost burned myself by mixing LOLIN I2C JST SH accessories and Adafruit QTPy, reverse way, I could have destroyed an Adafruit sensor by connecting it to Lolin S2 Pico. 2) The screen does not work as expected for a build-in screen, DISPLAY is not defined when you import board

I did hesitate between making a special section like "Caveats" or highlighting how it deviate from one can expect from a board running CircuitPython.

I try to manage expectation about this board and avoid short circuit or broken sensor.
1) I almost burned myself by mixing LOLIN I2C JST SH accessories and Adafruit QTPy, reverse way, I could have destroyed an Adafruit sensor by connecting it to Lolin S2 Pico.
2) The screen does not work as expected for a build-in screen, DISPLAY is not defined when you `import board`

I did hesitate between making a special section like "Caveats" or highlighting how it deviate from one can expect from a board running CircuitPython.
@dglaude dglaude changed the title Highlight incompatibilitiy with Adafruit ecosystem Highlight incompatibility with Adafruit ecosystem Dec 12, 2022
@deshipu
Copy link
Contributor

deshipu commented Dec 12, 2022

I suppose the display initialization could be added to board.c for this board?

@dglaude
Copy link
Contributor Author

dglaude commented Dec 13, 2022

Hi @deshipu , yes there must be a way to have the screen work as expected but apparently it is the first board where the screen is connected in I2C so there was no example to copy from.
adafruit/circuitpython#7325 (comment)

If this PR make's it, and then later someone implement that the proper way, we can remove the warning (or say starting with CP9.0.0-alpha1 this statement is not true anymore).

@evildave666
Copy link
Contributor

evildave666 commented Dec 16, 2022

To be fair, the S2 Pico circuitpython-org entry (I wrote it) does have a mention that the connector is not Stemma-QT pinout. I was concerned with this from the beginning.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One suggestion for increased clarity.

_board/lolin_s3.md Outdated Show resolved Hide resolved
dglaude and others added 2 commits December 29, 2022 00:50
Suggested by Dan. I need to apply the same warning for the other board.

Co-authored-by: Dan Halbert <[email protected]>
Make the warning match the other board, folowing Dan suggestion.
@dglaude
Copy link
Contributor Author

dglaude commented Dec 29, 2022

There might be a problem with the CI and Jekyll in particular, not sure why those simple change break it.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on Dan's previous review

@jepler jepler dismissed dhalbert’s stale review December 30, 2022 00:22

was done as requested

@jepler jepler merged commit b76a2be into adafruit:main Dec 30, 2022
@dglaude dglaude deleted the patch-7 branch January 1, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants