-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight incompatibility with Adafruit ecosystem #1114
Conversation
I try to manage expectation about this board and avoid short circuit or broken sensor. 1) I almost burned myself by mixing LOLIN I2C JST SH accessories and Adafruit QTPy, reverse way, I could have destroyed an Adafruit sensor by connecting it to Lolin S2 Pico. 2) The screen does not work as expected for a build-in screen, DISPLAY is not defined when you `import board` I did hesitate between making a special section like "Caveats" or highlighting how it deviate from one can expect from a board running CircuitPython.
I suppose the display initialization could be added to board.c for this board? |
Hi @deshipu , yes there must be a way to have the screen work as expected but apparently it is the first board where the screen is connected in I2C so there was no example to copy from. If this PR make's it, and then later someone implement that the proper way, we can remove the warning (or say starting with CP9.0.0-alpha1 this statement is not true anymore). |
To be fair, the S2 Pico circuitpython-org entry (I wrote it) does have a mention that the connector is not Stemma-QT pinout. I was concerned with this from the beginning. |
Just make it **bold**.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One suggestion for increased clarity.
Suggested by Dan. I need to apply the same warning for the other board. Co-authored-by: Dan Halbert <[email protected]>
Make the warning match the other board, folowing Dan suggestion.
There might be a problem with the CI and Jekyll in particular, not sure why those simple change break it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on Dan's previous review
I try to manage expectation about this board and avoid short circuit or broken sensor. 1) I almost burned myself by mixing LOLIN I2C JST SH accessories and Adafruit QTPy, reverse way, I could have destroyed an Adafruit sensor by connecting it to Lolin S2 Pico. 2) The screen does not work as expected for a build-in screen, DISPLAY is not defined when you
import board
I did hesitate between making a special section like "Caveats" or highlighting how it deviate from one can expect from a board running CircuitPython.