Skip to content

Conversation

@jepler
Copy link
Contributor

@jepler jepler commented Mar 28, 2022

click 8.1.0 is incompatible with typer. While there's an open PR to fix it in typer, we don't know when the fix will be released. So, just fix it by pinning known-compatible versions, including the transitive dependency we didn't explicitly list before.

jepler added 2 commits March 28, 2022 14:22
click 8.1.0 is incompatible with typer. While there's an open PR to fix it in
typer, we don't know when the fix will be released. So, just fix it by pinning
known-compatible versions, including the transitive dependency we didn't
explicitly list before.
@jepler
Copy link
Contributor Author

jepler commented Mar 28, 2022

A release will be needed after this change. Hopefully we can do it with credentials stored in this repo

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

@dhalbert dhalbert merged commit c6acf04 into main Mar 28, 2022
@dhalbert dhalbert deleted the pin-click-typer branch March 28, 2022 22:59
@tiangolo
Copy link

Hello! I just released Typer 0.4.1, you can now upgrade the version and possibly unpin Click. 🚀 🤓

@dhalbert
Copy link
Contributor

dhalbert commented Mar 30, 2022

Hello! I just released Typer 0.4.1, you can now upgrade the version and possibly unpin Click. rocket nerd_face

@tiangolo Thanks for the quick fix!

dhalbert added a commit that referenced this pull request Apr 2, 2022
Keep other changes from #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants