Automate community bundle list #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
commented
Jan 2, 2025
| ) | ||
| ) | ||
| release_required = True | ||
| if update_download_stats(bundle_path): |
Contributor
Author
There was a problem hiding this comment.
I also removed this code that updates the pypi stats. We're no longer using the stats in the file used for meeting notes so this does not need to update any longer.
Member
There was a problem hiding this comment.
If we don't use this, we can probably remove the Google BigQuery task that occurs in retrieve_pypi_stats() that feeds into update_download_stats(). I don't think we're billed over it, but probably worth doing if we're not using the download stats :) It's attached to my account I believe so I can do that. Then we can clean up some of the Actions secrets and decouple adabot from BigQuery entirely.
ladyada
approved these changes
Jan 2, 2025
Member
ladyada
left a comment
ladyada
left a comment
There was a problem hiding this comment.
looks ok to me but tbh im not familiar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: adafruit/CircuitPython_Community_Bundle#118
I tried to test this as best as possible, however all of it is kicked off by a higher level auto cron task that includes the releasing so I can only validate the smaller components easily.
I tested the updated list md generating code locally for both community bundle and adafruit bundle and the files seem good to me.
My understanding of the way the cron task works is the next run after this is merged will create and push
circuitpython_community_auto_library_list.mdinto the Community bundle repo. That file will get updated each time the task runs with any changes to the bundle.I made it a separate file with "auto" in the name because it compares to the existing content of the file and the format differs between the auto generated one and the manual one that exists in the community bundle. Once we have the content of this file we can paste it into
circuitpython_community_library_list.mdonce replacing the manually written content and we can remove "auto" from the name of the file here at the same time to complete the transition fully.This seemed like the safest way to migrate to the automated file to me so that we get a chance to look at the real generated list in the repo and verify it's good before making it automatically overwrite the old one.