Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip lib string before parse #376

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

FoamyGuy
Copy link
Contributor

For some reason some of the lib strings have a \r at the end of them i.e.

"[ticks](https://github.com/adafruit/Adafruit_CircuitPython_Ticks/releases/1.1.0)\r"

That causes parse.parse() to return None instead of the matched variables. Which then raises an exception 2 lines later when an attempt to access comps["link_comp"].

This resolves it by calling .strip() prior to parse() so that the string value will match the pattern that parse is expecting.

I tested it successfully by running python3 -m adabot.circuitpython_libraries with the appropriate env variables set up.

@FoamyGuy FoamyGuy requested a review from a team August 19, 2024 17:04
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 464d350 into adafruit:main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants