-
Notifications
You must be signed in to change notification settings - Fork 28
Added function to check that actions is passing #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jepler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks plausible but I did not do any testing.
sommersoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that needs to be addressed, and a couple (combined-ish) suggestions.
|
Ok. Made those changes. I tested it with the script (https://gist.github.com/dherrada/7843986c4890602bc13fffb53e5f82ff) I'm using to test just this method since update_cp_org_libraries takes ages to run. |
You can also run Also, to get this to run on |
Checking the diff, it looks like the submodule is actually fine. Since I'm already there, I'll go ahead and submit a PR to circuitpython-org to update the submodule. |
This runs when update_cp_org_libraries.py is run and should work with circuitpython.org/contributing