Skip to content

Conversation

@evaherrada
Copy link
Collaborator

This runs when update_cp_org_libraries.py is run and should work with circuitpython.org/contributing

@evaherrada evaherrada requested review from a team and kattni March 11, 2021 02:26
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks plausible but I did not do any testing.

Copy link
Collaborator

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that needs to be addressed, and a couple (combined-ish) suggestions.

@evaherrada evaherrada requested a review from sommersoft March 16, 2021 03:41
@evaherrada
Copy link
Collaborator Author

Ok. Made those changes. I tested it with the script (https://gist.github.com/dherrada/7843986c4890602bc13fffb53e5f82ff) I'm using to test just this method since update_cp_org_libraries takes ages to run.

@sommersoft
Copy link
Collaborator

I tested it with the script (https://gist.github.com/dherrada/7843986c4890602bc13fffb53e5f82ff) I'm using to test just this method since update_cp_org_libraries takes ages to run.

You can also run python -m adabot.circuitpython_libraries -v "validator_function, ..."; that's what I usually do when testing. The downside is that this method runs all of the reports, so it also takes some time to finish. (I would love to have another command arg to control this...but that would be a major refactor.)

Also, to get this to run on adafruit/circuitpython-org, the adabot submodule there will need to be updated. However, I think the submodule there is out-of-sync with the main branch here. Rebasing might be the way to go, but it will likely be messy and headache inducing.

@sommersoft sommersoft merged commit 61c7e4c into master Mar 16, 2021
@sommersoft
Copy link
Collaborator

However, I think the submodule there is out-of-sync with the main branch here. Rebasing might be the way to go, but it will likely be messy and headache inducing.

Checking the diff, it looks like the submodule is actually fine. Since I'm already there, I'll go ahead and submit a PR to circuitpython-org to update the submodule.

@evaherrada evaherrada deleted the actions-failure-check branch May 20, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants