Allow for power supply configuration #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seem like action ci need to change from setup node v1.1.0 to simply v1.1 to pass. I am on 2 days leave. Will merge now and fix the ci later on Update: oops, there is new power macros, will check it out later on |
Collaborator
Author
|
No rush! |
hathach
approved these changes
Dec 8, 2020
Member
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
thank you very much for the PR. To be honest, I haven't tested out the effect of using DCDC on actual hardware. However, since it does not change the behavior with default value and the modification look good enough.
This was referenced Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the MCU is supplied through its own LDO or DCDC, it's useful to configure that from bootloader. Many boards don't have an inductor for the DCDC0, but at least some modules have one for DCDC1, so I made them independent. The power consumption is about 2x lower with DCDC compared to LDO.