Update Depreciated Workflow Action #631
Conversation
| @@ -729,7 +729,7 @@ jobs: | |||
| run: | | |||
| zip -r wippersnapper.${{ matrix.arduino-platform }}.littlefs.${{ env.WS_VERSION }}.zip wippersnapper.${{ matrix.arduino-platform }}.littlefs.${{ env.WS_VERSION }}.* | |||
| - name: upload build artifacts zip | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: build-files-dev | |||
There was a problem hiding this comment.
Think this should also be build-files-dev-${{ matrix.arduino-platform }}.${{ env.WS_VERSION }} to make it easier to identify the inner contents of build zip assets
There was a problem hiding this comment.
@tyeth Which line are you specifically referring to? with: name: build-files-dev?
| with: | ||
| name: build-files | ||
| path: . |
There was a problem hiding this comment.
We need to test this with a pre-release.
I think we'll need to do some updating of io-rails to look for different files and now un-nest the build-files-{board}.{version}.zip to then get the original firmware uf2's and zips.
Alternatively we could alter the CI job, to either unzip the extra zip nesting, or unzip and merge all the build-files-(^dev).zip into a build-files.zip maybe as part of the previous build-clang-doxy CI job.
There was a problem hiding this comment.
I see what you're saying, everything is combined and io-rails is looking for the individually ZIPed assets
Alternatively we could alter the CI job, to either unzip the extra zip nesting, or unzip and merge all the build-files-(^dev).zip into a build-files.zip maybe as part of the previous build-clang-doxy CI job.
IMO this is preferable to modifying io-rails. Would you want to take this on?
There was a problem hiding this comment.
Done in branch add-merge-to-fix-upload-download-artifact-v4
Compare link: fix-upload-download-artifact...refs/heads/add-merge-to-fix-upload-download-artifact-v4
upload-artifact@v3will be deprecated in November 2024. This pull request updatesbuild-clang-doxy.ymlandrelease-callee.ymlto useupload-artifact@v4instead ofupload-artifact@v3and addresses the breaking changes for v4.Resolves: #611