Update record_ogg.ino #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing update of addr. Perhaps never noticed as it only addresses the last bytes to be written to the record
|
@ladyada can you have someone look at these pull requests? Many of them are years old. |
|
@sningo can you describe the issue that this fixes? What happens today and what is different with this fix? |
|
@johnwargo today: If more than one sample is available (line 147), then only the last collected word is being written/ earlier ones being overwritten, making the audio record incomplete. with the fix: Code snipped will probably do what it was initially intending (otherwise I cannot see any meaning in the declaration of the variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing update of addr. Perhaps never noticed as it only addresses the last bytes to be written to the record