Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup startPlayingFile #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheNitek
Copy link
Contributor

startPlayingFile seems overly complicated right now, so I'd suggest to to clean it up a bit. While filling the buffer initially sounds nice, it doesn't seem to bring any real benefit (you have to start refilling right away anyway).
Right now it's very confusing:

  • feedBuffer() is called within a loop that is happening within feedBuffer_noLock anyway
  • interrupts() is called afterwards even though interrupts are already enabled by feedBuffer()

In my opinion removing the complexity outweighs the "need" to initially fill the buffer.

@johnwargo
Copy link
Contributor

@TheNitek this PR is 5 years old now and nothing's happened with it. Close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants