Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scrolling capability #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

agprimatic
Copy link

With my changes to Adafruit-GFX-library, Adafruit_SSD1306 now supports scrolling text. When text is written to the bottom of the screen and scrolling is enabled, the screen will scroll up one line to make room for the next text line.

@tablatronix
Copy link

tablatronix commented Dec 31, 2016

Having a hard time understanding this pr, it looks like all you did was add doubling to y. What is the purpose of added function getpixel it does not seem related to this pr.

@agprimatic
Copy link
Author

The getpixel function is needed in the Adafruit_GFX library, which is where the scrolling is actually done. Since I was submitting commits for both Adafruit_GFX and adafruit_SSD1306, I used the same title so people know they go together.

@tablatronix
Copy link

Doh just noticed its two prs my bad
should maybe add a ref link to these to an issue or the other pr.

@maxint-rd
Copy link

maxint-rd commented Oct 28, 2017

See also different implementation in PR #56 and adafruit/Adafruit-GFX-Library#132
(I prefer a flexible implementation in Adafruit-GFX that allows driver developers to choose between simple yet slow getPixel() scrolling, faster buffer manipulation scrolling, or superfast hardware scrolling.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants