Remove legacy requests.set_socket #2743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Feb 29, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
We'll need someone to check all of the corresponding guides and update them too.
Contributor
Author
@tannewt is this something I can do? |
Contributor
|
[EDIT: @justmobilize says no] |
dhalbert
approved these changes
Feb 29, 2024
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks! This looks fine. I will look at the corresponding guides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove legacy
requests.set_socketand replace with newpoolandssl_contexthelpers from ConnectionManager