Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR14 Clean Up #22

Merged
merged 1 commit into from
Jan 15, 2024
Merged

PR14 Clean Up #22

merged 1 commit into from
Jan 15, 2024

Conversation

caternuson
Copy link
Contributor

This is just some clean up tweaks to #14.

  • Added header default so API isn't breaking.
  • Made bit shifts consistent (<< 5), even though POWERDOWN is just shifting 0's.

Tested with library example:
Screenshot from 2024-01-15 08-58-44

@caternuson
Copy link
Contributor Author

@ladyada for review

@caternuson caternuson merged commit d524860 into adafruit:master Jan 15, 2024
1 check passed
@ladyada
Copy link
Member

ladyada commented Jan 15, 2024

ugh this is why i prefer using RegisterBits for all new libraries. those bitshifts are such a mess 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caternuson @ladyada