Add Timezone support to receive_time and update tests (adjusted-time-failure)
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
force-pushed
the
update-tests-adjusted-time-failure
branch
2 times, most recently
from
e658439
to
a592bfb
Compare
tyeth
force-pushed
the
update-tests-adjusted-time-failure
branch
from
a592bfb
to
84577df
Compare
tyeth
changed the title
receive_time and update tests (adjusted-time-failure)
|
Hey @brentru, this is ready for review. This adds UTC timezone to the test's request, along with adding support for requesting the timezone via |
brentru
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the timezone argument to
receive_time, allowing users to request specific timezones rather than rely on autodetection.This also reduces the flakiness of the test
test_time_datawhich would intermittently fail depending if is_DST was 0 or 1 when the time struct was returned from the time service (GitHub runners are UTC and so is_DST=1 would fail when time struct passed to time.mktime)