Paho v1 compatibility #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
force-pushed
the
paho-v1-compatibility
branch
from
dc49ada
to
a0cb9f6
Compare
|
Tagging @brentru for review |
brentru
requested changes
Feb 15, 2024
|
@tyeth do you need a re-review? |
|
For some reason it wasn't showing me the latest commits when viewing feedback comments, but manually viewing all changes I've verified the errors are deleted and conversations are resolved @brentru . |
|
@tyeth Merged,could you create a new release and close out #152 (comment)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the API compatibility v1 argument to the client. It also uses paho errors instead of the MQTT_ERRORS collection from errors.py
They will be left for legacy reasons, but they don't match all the available errors so should not be relied upon.
Closes #152