Skip to content

Buffer length check in socket_write() #41

@bjnhur

Description

@bjnhur

I think, I found a bug in adafruit_wiznet5k/adafruit_wiznet5k.py

line 724, the code already has ret variable (SOCK_SIZE check & len of buffer)

if len(buffer) > SOCK_SIZE:
ret = SOCK_SIZE
else:
ret = len(buffer)

But, line 747, 751, didn't use this ret variable.

ptr = (ptr + len(buffer)) & 0xFFFF
self._write_sntx_wr(socket_num, ptr)
cntl_byte = 0x14 + (socket_num << 5)
self.write(dst_addr, cntl_byte, buffer)

Need to fix? My suggestion is:

        # update sn_tx_wr to the value + data size
        ptr = (ptr + ret) & 0xFFFF # <-- use ret
        self._write_sntx_wr(socket_num, ptr)

        cntl_byte = 0x14 + (socket_num << 5)
        txbuf = buffer[:ret] # <- use ret
        self.write(dst_addr, cntl_byte, txbuf) # <- use txbuf

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions