Skip to content

Clearer error raised when function gives improper HTTP response return #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhalbert merged 5 commits into from
Mar 16, 2022
Merged

Clearer error raised when function gives improper HTTP response return #13

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8034a81
Clearer error raised when function gives improper return
tekktrik Mar 9, 2022
7a50d44
Rework how return is parsed
tekktrik Mar 11, 2022
0bd806e
Merge isinstance calls
tekktrik Mar 11, 2022
a317a99
Change to catch ValueError and TypeError
tekktrik Mar 16, 2022
b92d562
Linted and reformatted
tekktrik Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions adafruit_wsgi/wsgi_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,17 @@ def __call__(self, environ: Dict[str, str], start_response: Callable):

if match:
args, route = match
status, headers, resp_data = route["func"](request, *args)

response_params = route["func"](request, *args)
if (
not isinstance(response_params, (list, tuple))
or len(response_params) != 3
):
raise RuntimeError(
"Proper HTTP response return not given for request handler '{}'".format(
route["func"].__name__
)
)
status, headers, resp_data = response_params
Comment thread
tekktrik marked this conversation as resolved.
Outdated
start_response(status, headers)
return resp_data

Expand Down