Skip to content

Make microseconds_to_angle() consistent with simpleio.Servo() #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannewt merged 2 commits into from
Aug 15, 2018
Merged

Make microseconds_to_angle() consistent with simpleio.Servo() #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d814f57
Make microseconds_to_angle() consistent with simpleio.Servo()
ScottDWebster Aug 13, 2018
6a3393e
Correct unit of time in the Servo class docstring
ScottDWebster Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions simpleio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ class Servo:
Easy control for hobby (3-wire) servos

:param ~microcontroller.Pin pin: PWM pin where the servo is located.
:param int min_pulse: Pulse width (microseconds) corresponding to 0 degrees.
:param int max_pulse: Pulse width (microseconds) corresponding to 180 degrees.
:param int min_pulse: Pulse width (milliseconds) corresponding to 0 degrees.
:param int max_pulse: Pulse width (milliseconds) corresponding to 180 degrees.

Example for Metro M0 Express:

Expand Down Expand Up @@ -220,7 +220,7 @@ def angle(self, degrees):

def microseconds_to_angle(self, us): #pylint: disable-msg=no-self-use, invalid-name
"""Converts microseconds to a degree value"""
return map_range(us, 500, 2500, 0, 180)
return map_range(us, self.min_pulse * 1000, self.max_pulse * 1000, 0, 180)

def deinit(self):
"""Detaches servo object from pin, frees pin"""
Expand Down