Skip to content

https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO/issues/10 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 18, 2018
Merged

https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO/issues/10 #30

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4efb124
https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO/issues/10…
May 15, 2018
b40cdbc
update docstring
May 15, 2018
47f5eb2
changed signature and docstring
May 18, 2018
42a5a37
changed signature again
May 18, 2018
2d969ba
fixed body to match new signature
May 18, 2018
5c0b8ed
Combine docs
tannewt May 18, 2018
a5f72b4
Remove trailing whitespace
tannewt May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions simpleio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,14 @@ class DigitalOut:
"""
Simple digital output that is valid until soft reset.
"""
def __init__(self, pin):
def __init__(self, pin, value=None, drive_mode=None):
Copy link
Member

@tannewt tannewt May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler to do def __init__(self, pin, **kwargs):

"""
value and drive_mode: if passed in will be passed to switch_to_output
see digitalio.DigitalInOut.switch_to_output for more details
Copy link
Member

@tannewt tannewt May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy the docs here. Directing elsewhere doesn't simplify the docs.

"""
kwargs = {k: v for k, v in (('value', value), ('drive_mode', drive_mode)) if not v is None}
self.iopin = digitalio.DigitalInOut(pin)
self.iopin.switch_to_output()
self.iopin.switch_to_output(**kwargs)

@property
def value(self):
Expand All @@ -247,9 +252,14 @@ class DigitalIn:
"""
Simple digital input that is valid until soft reset.
"""
def __init__(self, pin):
def __init__(self, pin, pull=None):
"""
pull: if passed in will be passed to switch_to_input
see digitalio.DigitalInOut.switch_to_input for more details
"""
kwargs = {k: v for k, v in (('pull', pull),) if not v is None}
self.iopin = digitalio.DigitalInOut(pin)
self.iopin.switch_to_input()
self.iopin.switch_to_input(**kwargs)

@property
def value(self):
Expand Down