Switch to adafruit_bus_device dependency #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Mar 14, 2022
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Code change makes sense and looks good to me.
I don't have the Sharp display to test it though. Will leave open for now, hopefully we can get someone with the display to try it out.
jepler
reviewed
Mar 18, 2022
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
Seems fine, also didn't test. Thank you!
Member
Author
|
Should I wait for a test or go ahead and merge with the approvals? |
# Conflicts: # adafruit_sharpmemorydisplay.py
FoamyGuy
approved these changes
Apr 25, 2022
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
I merged main to resolve conflicts and tested this successfully on Feather RP2040 with https://www.adafruit.com/product/3502 using the simpletest example in this repo. Everything is working as intended as far as I can tell.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 26, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.3.9 from 3.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SD#48 from tekktrik/doc/add-typing > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.4.0 from 1.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#21 from tekktrik/dev/switch-bus-device > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#19 from ilikecake/image-function-numpy > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.13.0 from 1.12.0: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#70 from FoamyGuy/dont_require_secrets_if_no_network > change discord badge > Patch: Replaced discord badge image > Updated gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
adafruit_bus_device.spi_device.SPIDevicecan now handle inverted CS pins, this PR switches it over to using it! Also should add everything needed in the infrastructure and documentation to support this change.Resolves #20
Still needs to be tested.