Changed 1 character. Should fix stuff #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Aug 7, 2020
|
It seems like there are issues with signing using sha based on the test file. I don't think the issues are related to this one. I haven't gotten to the end of the test file yet but I'll just use a try/except to find out how each one is failing. I'll open an issue, and if it seems easy enough, fix it. |
Merged
|
@dherrada Could you attach the REPL output of |
|
@brentru sure. Here ya go |
brentru
approved these changes
Aug 7, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 11, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#12 from FoamyGuy/fix_for_board_without_display Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_RSA#14 from adafruit/sha_fix > Merge pull request adafruit/Adafruit_CircuitPython_RSA#12 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MatrixPortal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpletest currently works. I'm running rsa_tests right now, and it's running better than it was before, although I'm not convinced this was the only issue.