raise explanatory exception when trying to set channel frequency #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Jul 31, 2018
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Looks great! I caught those typos when researching this bug - good catch and thanks for fixing them up as well.
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 1, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.0.7 from 3.0.6: > travis: add "overwrite: true" to releases provider Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.2.0 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#13 from kattni/pypi > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#14 from dhalbert/notimpl-freq-setter Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.0.0 from 0.9.1: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#8 from kattni/pypi Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.0 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#14 from kattni/pypi > Merge pull request adafruit/Adafruit_CircuitPython_Motor#13 from dhalbert/stepper-freq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a useful exception message when trying to set frequency of an individual channel. This might happen if the overall frequency is too low for a stepper motor, for instance. See adafruit/Adafruit_CircuitPython_Motor#12.