Skip to content

MQTT connect with an empty username should have the proper header #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekktrik merged 1 commit into from
Dec 5, 2022
Merged

MQTT connect with an empty username should have the proper header #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions adafruit_minimqtt/adafruit_minimqtt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ def connect(self, clean_session=True, host=None, port=None, keep_alive=None):

# Set up variable header and remaining_length
remaining_length = 12 + len(self.client_id.encode("utf-8"))
if self._username:
if self._username is not None:
remaining_length += (
2
+ len(self._username.encode("utf-8"))
Expand Down Expand Up @@ -532,9 +532,7 @@ def connect(self, clean_session=True, host=None, port=None, keep_alive=None):
# [MQTT-3.1.3-11]
self._send_str(self._lw_topic)
self._send_str(self._lw_msg)
if self._username is None:
self._username = None
else:
if self._username is not None:
self._send_str(self._username)
self._send_str(self._password)
if self.logger is not None:
Expand Down