Make MQTT__init__ arguments keyword-only #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamblor21
approved these changes
Sep 2, 2022
Member
gamblor21
left a comment
gamblor21
left a comment
There was a problem hiding this comment.
Looks good to me. Just unsure if anything needs to be tweaked to tag it for 8.x since it is technically API breaking?
Member
Author
|
I think it's fine, but I'll sit on tonight and see if anyone in #circuitpython-dev knows more about that! |
Member
Author
|
Converted to draft so it doesn't merge before I can ask about this! |
Contributor
|
I agree it's fine, with a major version bump, if you've checked the Learn Guides repo and the library examples. |
Member
Author
|
Checked the libraries and Learn Guides repositories, we're good! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 8, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_Nunchuk to 1.1.7 from 1.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#32 from tekktrik/doc/fix-typing > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.0.2 from 6.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#132 from vladak/wait_for_msg_cleanup > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#130 from flavio-fernandes/username_fix > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#121 from tekktrik/dev/kw-init > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.9.15 from 1.9.14: > Merge pull request adafruit/Adafruit_CircuitPython_Register#49 from tekktrik/fix/pinned-typing > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is API-breaking, but hopefully makes using the library less prone to errors. I couldn't find any existing libraries or Learn Guides (save for one that's already broken with regards to API since it hasn't been updated for the last API-breaking change to
MQTT.__init__()).Resovles #120