fix temperature calculation #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
approved these changes
Mar 20, 2022
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
Looks good to me! Didn't test myself, but definitely seems to agree with the datasheet much more like you say. Thanks!
FoamyGuy
approved these changes
Mar 20, 2022
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
tested successfully with LSM6DS33. Temperature values do look much more accurate in my case as well. Was showing negative values with current implementation and roughly room temp with these changes.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 21, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.4.2 from 4.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#55 from jerryneedell/jerryn_temperature > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#53 from infamy/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7565 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_ST7565#4 from U47/patch > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.7 from 1.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#31 from makermelissa/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #54
Tested with lsm6dsox and lsm6ds33 on QTPy_esp32s2
Yields much more reasonable temperatures than the current implementation.