Skip to content

Adding Type Annotations #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2023
Merged

Adding Type Annotations #76

merged 3 commits into from
Jan 20, 2023

Conversation

@jposada202020
Copy link
Contributor

@jposada202020 jposada202020 commented Jan 19, 2023 •
edited
Loading

Adding Type Annotations Solves #69

Thanks

@jposada202020 jposada202020 requested a review from a team January 19, 2023 15:48
@tekktrik tekktrik linked an issue Jan 19, 2023 that may be closed by this pull request
Missing Type Annotations #69
Closed
16 tasks
tekktrik
tekktrik requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! I added some feedback below:

tekktrik
tekktrik approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fixes!

@tekktrik tekktrik merged commit 61ca587 into adafruit:main Jan 20, 2023
@jposada202020 jposada202020 deleted the type_annotations branch January 20, 2023 11:46
@jposada202020
Copy link
Contributor Author

jposada202020 commented Jan 20, 2023

Thank you!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 21, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@6174d7e)
15328fb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.21 from 5.1.20:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#76 from jposada202020/type_annotations
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.3.8 from 6.3.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#147 from tekktrik/patch/release-ci
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#145 from tekktrik/fix/gitignore-venv

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8574 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8574#7 from tcfranks/main
  > Add upload url to release action
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8574#6 from tekktrik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Type Annotations

2 participants

@jposada202020 @tekktrik