Skip to content

Close #174 by sending entire webserver response to ESP32 in one go if possible #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Close #174 by sending entire webserver response to ESP32 in one go if possible #175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f2b40e
close #174
rivques Sep 10, 2022
c50a103
make black happy
rivques Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions adafruit_esp32spi/adafruit_esp32spi_wsgiserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,16 @@ def finish_response(self, result):
response += "{0}: {1}\r\n".format(*header)
response += "\r\n"
self._client_sock.send(response.encode("utf-8"))
for data in result:
if isinstance(data, bytes):
self._client_sock.send(data)
else:
self._client_sock.send(data.encode("utf-8"))
if isinstance(result, bytes): # send whole response if possible (see #174)
self._client_sock.send(result)
elif isinstance(result, str):
self._client_sock.send(result.encode("utf-8"))
else: # fall back to sending byte-by-byte
for data in result:
if isinstance(data, bytes):
self._client_sock.send(data)
else:
self._client_sock.send(data.encode("utf-8"))
gc.collect()
finally:
if self._debug > 2:
Expand Down