Skip to content

fix calls to displayio.TileGrid usage of position #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ladyada merged 1 commit into from
Mar 14, 2019
Merged

fix calls to displayio.TileGrid usage of position #6

ladyada merged 1 commit into from
Mar 14, 2019

Conversation

@jerryneedell
Copy link
Contributor

@jerryneedell jerryneedell commented Mar 14, 2019

@jerryneedell jerryneedell requested a review from ladyada March 14, 2019 21:17
@jerryneedell
Copy link
Contributor Author

jerryneedell commented Mar 14, 2019

tested by running eventcoundown example


Press any key to enter the REPL. Use CTRL-D to reload.
Adafruit CircuitPython 4.0.0-beta.3-38-g74083dafe on 2019-03-13; Adafruit PyPortal with samd51j20
>>> 
>>> 
>>> import eventcountdown
ESP firmware: bytearray(b'1.2.2\x00')
Set background to  /countdown_background.bmp
Getting time from internet!
Connecting to AP Needell Airport
Cound not connect to internet ('No such ssid', b'Needell Airport')
Retrying in 3 seconds...
Connecting to AP Needell Airport
Getting time for timezone America/New_York
struct_time(tm_year=2019, tm_mon=3, tm_mday=14, tm_hour=17, tm_min=19, tm_sec=29, tm_wday=4, tm_yday=73, tm_isdst=None)
Current time: struct_time(tm_year=2019, tm_mon=3, tm_mday=14, tm_hour=17, tm_min=19, tm_sec=29, tm_wday=3, tm_yday=73, tm_isdst=-1)
Time remaining (s): 2734831
31 days, 15 hours, 40 minutes and 31 seconds

also works on older release

@ladyada
Copy link
Member

ladyada commented Mar 14, 2019

didn't test but looks correct!

@ladyada ladyada merged commit fe32558 into adafruit:master Mar 14, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 15, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@52a9ec7)
5dcc668 
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.2.2 from 2.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#35 from adafruit/tannewt-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#15 from jerryneedell/jerryn_fix_tilegrid

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#6 from jerryneedell/jerryn_fix_tilegrid

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.7.3 from 1.7.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#36 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#24 from siddacious/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ladyada ladyada ladyada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jerryneedell @ladyada