Update Button class to match debouncer logic #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button.short_countandButton.long_pressnow return a consistent value that only changes whenButton.update()is called, likeroseandfelldo. This is important for the logic of the debouncer to work, where the status of the button should be stable during a "frame".The
active_downparameter is changed tovalue_when_pressed, a clearer name with the opposite value (also used in the keypad module). Withactive_downset to True, the active value when the button is pressed is False.Expose
Button.pressedandButton.released, while rose/fell remain the lower level signal direction of the edge.Note that
short_countchanges value after theshort_duration_msdelay, so as to not report a double click as a simple click, so you would either use pressed/released if you don't look for double clicks orshort_count == 1to detect a click,2for a double-click and more. Is that confusing ?Maybe
value_when_pressedandpressed/releasedcould be moved into the Debouncer class.