Fix issue 54 #55
Merged
Fix issue 54 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NotImplementedError on catched exceptions.
makermelissa
approved these changes
Dec 19, 2020
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Ok, I had to look at several of the issues and PRs you referenced to figure out what this was accomplishing. Looks good.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.3 from 3.5.2: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#55 from yeyeto2788/fix_issue_54 Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#23 from FoamyGuy/fix_hardcoded_baudrate Updating https://github.com/adafruit/Adafruit_CircuitPython_BitbangIO to 1.2.0 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#13 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#12 from alustig3/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#29 from FoamyGuy/fallback_without_json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NotImplementedError on catched exceptions.
Fixes #54