Update to use root_group for CP 9 compatibility #61
Conversation
There was a problem hiding this comment.
I believe the show and show_terminal methods in the actual library adafruit_clue.py both need the root_group= update. It also looks like the show_terminal method currently doesn't work as I believe showing the None group results in a blank screen not the terminaio screen. the show_terminal method should assign the root_group to displayio.CIRCUITPYTHON_TERMINAL
There was a problem hiding this comment.
I pushed some commits that update the show() and show_terminal() methods of the simple text helper inner class as noted.
The displayio import was tricky to get working. I moved it to the outter level for now because it satisfies both pylint and sphinx docs build. It's worth another look in the future to see if it can be changed to the more specific from displayio import CIRCUITPYTHON_TERMINAL but that was causing the docs build to fail when I tried it.
The current version looks good to me. I tested successfully on a clue with 9.0.0 alpha.
Thank you @prcutler for submitting this and @RetiredWizard for taking a look over it!
Updating https://github.com/adafruit/Adafruit_CircuitPython_24LC32 to 1.1.0 from 1.0.12: > Merge pull request adafruit/Adafruit_CircuitPython_24LC32#23 from TonyLHansen/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 2.0.0 from 1.3.13: > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#24 from jposada202020/improving_lib Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 3.1.0 from 3.0.17: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#61 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.14 from 3.4.13: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#59 from bdlucas1/main Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.8.1 from 5.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#114 from kavinaidoo/main Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.3.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#59 from imnotjames/chore/optional-traceback Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 0.0.7 from 0.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#15 from adafruit/enhancements > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#13 from brentru/allow-jpg-save Updating https://github.com/adafruit/Adafruit_CircuitPython_TemplateEngine to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TemplateEngine#2 from michalpokusa/removing-8-x-x-re-module-bug-workarounds Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Fix #60