Add optional dependencies to pyproject.toml #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jposada202020
approved these changes
Feb 4, 2023
Contributor
jposada202020
left a comment
jposada202020
left a comment
There was a problem hiding this comment.
Thank you, LGTM. Changes are aligned with other Adafruit libraries. Thanks :)
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 5, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.4.12 from 3.4.11: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#58 from tekktrik/dev/add-opp-deps > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.2.7 from 1.2.6: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#35 from Neradoc/documentation-for-raw-text-packet > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.4.8 from 3.4.7: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#70 from makermelissa/master > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional dependencies to
pyproject.toml, which aren't currently used now but this format is consistent across the other libraries. This will make adabot patching more reliable, at least, should that be needed.Fixes #57