Lint #1
Merged
Lint #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
approved these changes
Dec 19, 2019
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good, not tested.
Contributor
|
I am finding some problems, testing on hardware, so hold on. |
Member
Author
|
@dhalbert I had the services import wrong so make sure you have that. (Just tested it myself.) |
dhalbert
requested changes
Dec 19, 2019
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
In adafruit_ble_magic_light.py,
This line:
from adafruit_ble.service import Service
needs plural .services:
from adafruit_ble.services import Service
After that change:
Does not work with beta.1, does work with circuitpython commit f2b1aeeed. I'm having trouble building the tip of master.
Contributor
|
yup, we both found the same thing. |
dhalbert
approved these changes
Dec 19, 2019
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Tested in a lamp, now works! I assume I am spooking out people passing in the street.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.