fix scan filtering for cases like (Advertisement, SubclassOfAdvertisment) #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
start_scan-prefix-fix
branch
from
904f8ae to
354134f
Compare
…ure__ import annotations
dhalbert
force-pushed
the
start_scan-prefix-fix
branch
from
354134f to
8e32223
Compare
Collaborator
Author
|
anecdata tested and verified |
ladyada
approved these changes
Jun 28, 2020
Member
ladyada
left a comment
ladyada
left a comment
There was a problem hiding this comment.
didnt test but did look at the diffs!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 29, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#57 from caternuson/iss55 Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 7.0.1 from 7.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#93 from dhalbert/start_scan-prefix-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92.
start_scan() did not handle the case of mixing an
Advertisementclass with no prefixes with classes with some prefixes. This is used inexamples/ble_detailed_scan.py.Thanks to anecdata (in discord) for spotting this problem.