Allow group feeds to be subscribed to and unsubscribed from #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to subscribe to a group feed because
IO_MQTT#subscribe
validatesfeed_key
unconditionally. Whengroup_key
is provided instead offeed_key
,feed_key
should not be required to be valid. This issue is also present inIO_MQTT#unsubscribe
.This change makes it so that
IO_MQTT#subscribe
andIO_MQTT#unsubscribe
validatefeed_key
andgroup_key
only when one is provided.