Chunks not working on ESP32

[caternuson]

Related:
https://forums.adafruit.com/viewtopic.php?f=25&t=183433

Recreated using pixels_test example from AMG88xx library.

Seems related to usage of stop parameter here:

Adafruit_BusIO/Adafruit_I2CDevice.cpp

Line 179 in b903c7e

if (!_read(read_buffer, read_len, false)) {

which was not in previous chunk code:
https://github.com/adafruit/Adafruit_AMG88xx/blob/90e9eea8c43b6a173f10029029cec85ab1818823/Adafruit_AMG88xx.cpp#L234

[ladyada]

erm, should probably pass stop thru there yeah?

[caternuson]

It's passing through to the actual read start here:

Adafruit_BusIO/Adafruit_I2CDevice.cpp

Line 193 in b903c7e

size_t recv = _wire->requestFrom((uint8_t)_addr, (uint8_t)len, (uint8_t)stop);

But seems to be more fundamentally broken. Better example. Using a Feather ESP32. Nothing fancy, just try a read of 32 bytes:

#include <Wire.h>

#define WIRE Wire
#define I2C_ADDRESS (0x69)
#define READ_SIZE (32)

void setup() {
  Serial.begin(9600);
  while(!Serial);

  uint8_t buffer[READ_SIZE];
  
  WIRE.begin();
  WIRE.requestFrom(I2C_ADDRESS, 32, true);
  uint32_t count = 0;
  while (WIRE.available() and count < READ_SIZE) {
    buffer[count++] = WIRE.read();
  }
}

void loop() {
}

Generates expected traffic:

Change:

  WIRE.requestFrom(I2C_ADDRESS, 32, true);

to:

  WIRE.requestFrom(I2C_ADDRESS, 32, false);

and nothing happens on the bus.

Above test done with ESP32 BSP 2.0.0

[ladyada]

try using something else, esp 2.0.0 broke a ton of stuff

[caternuson]

Just to document behavior on a different platform - Qt Py M0

stop = true

stop = false

[ladyada]

k, looks right to me, there's a stop in the first one, none in the second

[caternuson]

Yep. Just documenting expected behavior. Qt Py works as expected.

Just tried with ESP32 BSP 1.0.6 and same results as with BSP 2.0.0.

[ladyada]

yah ok try
espressif/arduino-esp32#4729 (comment)

[caternuson]

hey! i know that pr :)
espressif/arduino-esp32#5470 (comment)

it does something different, but not the expected. basically same behavior either way.

stop = true

stop = false

[ladyada]

ok please reply to that PR with the deets of what isnt workin

[caternuson]

Closing. For now at least. The base issue for this is in the ESP32 BSP and, per comment here:
espressif/arduino-esp32#5702 (comment)
can not be supported for ESP32.