Fix TileGrid flip_x, flip_y and transpose_xy#107
Merged
Conversation
|
@s-ol Just wanted to say thank you!!!!. This makes display_text PRs much easier.
without you PR...
|
makermelissa
approved these changes
Mar 27, 2023
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good. Thanks for finding and fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The != works as an 'xor' condition on the booleans, since each of the transforms is a noop if executed twice.
This works as expected with all my existing CPy code, but I haven't done testing with a parent Group that has its own transform, so the order in which these are applied and possible interactions should still be verified against the native implementation.
Close #106