Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: implement parsing for expected_match field #821

Closed
wants to merge 168 commits into from
Closed

[WIP] feat: implement parsing for expected_match field #821

wants to merge 168 commits into from

Conversation

mertcanaltin
Copy link
Contributor

@mertcanaltin mertcanaltin commented Jan 2, 2025 •
edited
Loading

I added parsing logic for expected_match to handle strings, null values, and objects safely

@lemire @anonrig

anonrig and others added 30 commits December 12, 2024 19:09
@anonrig
implement URLPattern skeleton
b963c09
@anonrig
use correct value for clang-format
668f950
@anonrig
fix build errors
f0cfe7b
@anonrig
create url_pattern-inl.h
9772f44
@anonrig
add canonicalize methods
d0abcff
@anonrig
add ada::parse_url_pattern function
8e7ac7c
@anonrig
add more comments
62eba64
@anonrig
implement getters
f2a1b1d
@anonrig
add has_regexp_groups()
ee48e30
@anonrig
start implementing tokenizer & tokenize
615f1ef
@anonrig
add initial parser_url_pattern method
5a27a07
@anonrig
add todos and remove redundant qualifiers
6634c09
@anonrig
implement escape pattern
e1ea3a1
@anonrig
add CompileComponentOptions
a5ffd39
@lemire @anonrig
minor fixes for add-url-pattern (ada-url#800)
9899579
@anonrig
rename commits
7c40686
@anonrig
add more parse_url_pattern
ce624cd
@anonrig
rename url_pattern class
d1b3af1
@anonrig
complete parse_url_pattern implementation
b8b2d4d
@anonrig
add _component suffix to components
770a221
@anonrig
remove unnecessary void
66d2a67
@anonrig
implement generate regular expression methods
af903a1
@anonrig
continue working on parser
2df15e8
@anonrig
fix build error
22295d4
@anonrig
implement constructor string parser
5a66288
@anonrig
implement all of tokenizer's functions
f72fb07
@anonrig
fix build errors
b424fd7
@anonrig
fix warnings
62f17fa
@anonrig
complete tokenizer
e18f51e
@anonrig
implement escape_regexp_string
ab16828
@anonrig anonrig force-pushed the yagiz/add-url-pattern branch from 9f8b316 to ab605c6 Compare January 3, 2025 18:18
@mertcanaltin mertcanaltin changed the title feat: implement parsing for expected_match field [WIP] feat: implement parsing for expected_match field Jan 4, 2025
@anonrig anonrig force-pushed the yagiz/add-url-pattern branch from 8a44b81 to 1c431ba Compare January 4, 2025 19:29
@anonrig anonrig force-pushed the yagiz/add-url-pattern branch from 1c431ba to 5d73064 Compare January 4, 2025 19:31
@lemire lemire force-pushed the yagiz/add-url-pattern branch from 69b8fc0 to 8a44b81 Compare January 4, 2025 21:00
@anonrig anonrig force-pushed the yagiz/add-url-pattern branch from d696f95 to 3f959ca Compare January 5, 2025 00:28
@anonrig anonrig force-pushed the yagiz/add-url-pattern branch 2 times, most recently from 65c0406 to 61728b2 Compare January 8, 2025 15:20
@anonrig anonrig deleted the branch ada-url:yagiz/add-url-pattern January 8, 2025 15:36
@anonrig anonrig closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mertcanaltin @anonrig @lemire