Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate check on path_signature_table #669

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: remove duplicate check on path_signature_table #669

merged 1 commit into from
May 17, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 17, 2024

No description provided.

@anonrig anonrig requested a review from lemire May 17, 2024 02:58
lemire
lemire approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Note that a compiler will optimize this away. Still worth it to remove it to make the code more readable.

@anonrig anonrig merged commit 7e83d64 into main May 17, 2024
36 checks passed
@anonrig anonrig deleted the remove-duplicate-check branch May 17, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anonrig @lemire