Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent missing python warning when format feature not requested #636

Merged
merged 1 commit into from
Apr 28, 2024
Merged

prevent missing python warning when format feature not requested #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 31 additions & 27 deletions cmake/clang-format.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,41 @@
find_program(PYTHON_EXECUTABLE python3 python)

if(NOT PYTHON_EXECUTABLE)
message(WARNING "Python not found. Skipping lint and format checks.")
if(NOT DEFINED ENV{LINT_AND_FORMAT_CHECK} AND NOT DEFINED ENV{FORMAT_ENABLED} )
# empty early exit, do not look for python
else()
set(LINT_AND_FORMAT_SCRIPT_PATH ${CMAKE_SOURCE_DIR}/tools/lint_and_format.py)

# Should run on CI
if(DEFINED ENV{LINT_AND_FORMAT_CHECK})
message(STATUS "Checking code with clang-format...")
execute_process(
COMMAND ${PYTHON_EXECUTABLE} ${LINT_AND_FORMAT_SCRIPT_PATH} check
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
RESULT_VARIABLE clang_check_result
)

if(clang_check_result)
message(FATAL_ERROR "Clang-format check failed with error code ${clang_check_result}")
endif()
find_program(PYTHON_EXECUTABLE python3 python)

if(NOT PYTHON_EXECUTABLE)
message(WARNING "Python not found. Skipping lint and format checks.")
else()
if(DEFINED ENV{FORMAT_ENABLED})
message(STATUS "Formatting code with clang-format...")
set(LINT_AND_FORMAT_SCRIPT_PATH ${CMAKE_SOURCE_DIR}/tools/lint_and_format.py)

# Should run on CI
if(DEFINED ENV{LINT_AND_FORMAT_CHECK})
message(STATUS "Checking code with clang-format...")
execute_process(
COMMAND ${PYTHON_EXECUTABLE} ${LINT_AND_FORMAT_SCRIPT_PATH} format
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
RESULT_VARIABLE clang_format_result
COMMAND ${PYTHON_EXECUTABLE} ${LINT_AND_FORMAT_SCRIPT_PATH} check
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
RESULT_VARIABLE clang_check_result
)

if(clang_format_result)
message(FATAL_ERROR "Clang-format format failed with error code ${clang_check_result}")
if(clang_check_result)
message(FATAL_ERROR "Clang-format check failed with error code ${clang_check_result}")
endif()

else()
message(STATUS "Code formatting is not enabled.")
if(DEFINED ENV{FORMAT_ENABLED})
message(STATUS "Formatting code with clang-format...")
execute_process(
COMMAND ${PYTHON_EXECUTABLE} ${LINT_AND_FORMAT_SCRIPT_PATH} format
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
RESULT_VARIABLE clang_format_result
)

if(clang_format_result)
message(FATAL_ERROR "Clang-format format failed with error code ${clang_check_result}")
endif()
else()
message(STATUS "Code formatting is not enabled.")
endif()
endif()
endif()
endif()
endif()
Loading