You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
Describe the bug
Github automatically creates source code archives which are commonly used by distros to fetch repositories at point releases.
These do not include the .git directory. Consequently, UWUFETCH_VERSION = $(shell git describe --tags) sets an empty string at compile time.
Expected behavior
Sensible version string regardless of vcs presence in archive. I propose to hardcode the string and update it upon release of a new version. Another option would be to allow users to pass the string as a make argument but this doesn't seem correct to me.
Desktop (please complete the following information):
OS: any
Version since 2.0
Are you already working on this bug?
I want your feedback on my proposition before proceeding with my proposition.
The text was updated successfully, but these errors were encountered:
I implemented a more complex way to "hard code" version tags. Now compiler info is included (for possible debugging purposes), git tag description and the version tag (hard coded as you suggested). Of course the bug will be actually fixed in the next release. I will close the issue before releasing 2.2 (or maybe 3.0, idk)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
Github automatically creates source code archives which are commonly used by distros to fetch repositories at point releases.
These do not include the
.git
directory. Consequently,UWUFETCH_VERSION = $(shell git describe --tags)
sets an empty string at compile time.To Reproduce
Steps to reproduce the behavior:
make build
Expected behavior
Sensible version string regardless of vcs presence in archive. I propose to hardcode the string and update it upon release of a new version. Another option would be to allow users to pass the string as a make argument but this doesn't seem correct to me.
Desktop (please complete the following information):
Are you already working on this bug?
I want your feedback on my proposition before proceeding with my proposition.
The text was updated successfully, but these errors were encountered: