suggested changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt section (i.e., revert to status quo for SortIndexedProperties) Usually, within a "Properties of some Object" section, the child-sections are only for actual properties, not for related abstract operations.
Usually, in a "Properties of some Object" section, the child sections (or at least the ones with straightforward names) are in alphabetical order.
…edArray Objects"
ljharb
reviewed
Jan 20, 2023
| <h1> | ||
| CompareTypedArrayElements ( | ||
| _x_: a Number or a BigInt, | ||
| _y_: a Number or a BigInt, |
There was a problem hiding this comment.
this should accompany changing the assertion in step 1 to Assert: Type(_x_) is Type(_y_)
There was a problem hiding this comment.
I'll merge this into the existing PR as is for now. Feel free to add the comment back on the primary PR.
|
thanks @jmdyck ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.