Skip to content

Fix docker images#7146

Merged
MikesGlitch merged 2 commits intoactualbudget:masterfrom
MikesGlitch:fix-docker-images
Mar 6, 2026
Merged

Fix docker images#7146
MikesGlitch merged 2 commits intoactualbudget:masterfrom
MikesGlitch:fix-docker-images

Conversation

@MikesGlitch
Copy link
Copy Markdown
Member

@MikesGlitch MikesGlitch commented Mar 6, 2026

Description

Fixing migrations retrieval - it was caused by the typescript updates that have come in recently. We now need to filter out the *.d.ts files so the migration runner doesn't run them.

Docker has been failing to publish since two days ago, I think it was introduced with #7062

As can be seen here: https://github.com/actualbudget/actual/actions/workflows/docker-edge.yml

Related issue(s)

We're getting this error when running the docker image in the pipeline & locally:

at next (/app/node_modules/migrate/lib/migrate.js:26:17)
at migrate (/app/node_modules/migrate/lib/migrate.js:76:3)
at MigrationSet.migrate (/app/node_modules/migrate/lib/set.js:123:3)
at MigrationSet.up (/app/node_modules/migrate/lib/set.js:107:8)
at file:///app/src/migrations.js:26:31
at /app/node_modules/migrate/index.js:62:5
at /app/node_modules/migrate/lib/load-migrations.js:97:7
at ReadFileContext.callback (/app/node_modules/migrate/lib/file-store.js:37:14)
at FSReqCallback.readFileAfterOpen [as oncomplete] (node:fs:297:13)

Testing

Built and ran it locally

image

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 6, 2026

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e120134
🔍 Latest deploy log https://app.netlify.com/projects/actualbudget/deploys/69ab4e1c6aca0600087a3fa5
😎 Deploy Preview https://deploy-preview-7146.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

👋 Hello contributor!

We would love to review your PR! Before we can do that, please make sure:

  • ✅ All CI checks pass
  • ✅ The PR is moved from draft to open (if applicable)
  • ✅ The "[WIP]" prefix is removed from the PR title
  • ✅ All CodeRabbit code review comments are resolved (if you disagree with anything - reply to the bot with your reasoning so we can read through it). The bot will eventually approve the PR.

We do this to reduce the TOIL the core contributor team has to go through for each PR and to allow for speedy reviews and merges.

For more information, please see our Contributing Guide.

@MikesGlitch MikesGlitch marked this pull request as ready for review March 6, 2026 22:02
@MikesGlitch MikesGlitch requested a review from matt-fidd as a code owner March 6, 2026 22:02
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 6, 2026

📝 Walkthrough

Walkthrough

The pull request updates migration file filtering logic to exclude TypeScript declaration files (.d.ts) and adds a corresponding release note documenting this bugfix for Docker image execution.

Changes

Cohort / File(s) Summary
Migration File Filtering
packages/sync-server/src/migrations.ts
Updated filtering logic to exclude TypeScript declaration files (.d.ts) from migration module imports, preventing declaration files from being incorrectly loaded as migrations.
Release Documentation
upcoming-release-notes/7146.md
Added release note entry documenting the bugfix for migrations retrieval when running Docker images.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

size small

Poem

🐰 With whiskers twitched and nose in air,
Declaration files? We don't load there!
Migrations clean, no .d.ts found,
Docker images leap without a bound! 🚀

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix docker images' is vague and does not clearly convey the specific change, which is filtering out TypeScript declaration files from migrations retrieval. Consider a more specific title like 'Fix migrations retrieval by excluding .d.ts files' to better communicate the actual technical change being made.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly explains the problem (migrations running on .d.ts files after TypeScript updates), the solution (filtering out *.d.ts files), and provides context including error logs and related PR reference.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MikesGlitch MikesGlitch enabled auto-merge March 6, 2026 22:16
@MikesGlitch MikesGlitch added this pull request to the merge queue Mar 6, 2026
Merged via the queue into actualbudget:master with commit b727124 Mar 6, 2026
25 checks passed
@MikesGlitch MikesGlitch deleted the fix-docker-images branch March 6, 2026 22:59
matt-fidd pushed a commit to matt-fidd/actual that referenced this pull request Mar 25, 2026
* fix docker images

* release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants