Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hello contributor! We would love to review your PR! Before we can do that, please make sure:
We do this to reduce the TOIL the core contributor team has to go through for each PR and to allow for speedy reviews and merges. For more information, please see our Contributing Guide. |
📝 WalkthroughWalkthroughThe pull request updates migration file filtering logic to exclude TypeScript declaration files (.d.ts) and adds a corresponding release note documenting this bugfix for Docker image execution. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* fix docker images * release notes
Description
Fixing migrations retrieval - it was caused by the typescript updates that have come in recently. We now need to filter out the
*.d.tsfiles so the migration runner doesn't run them.Docker has been failing to publish since two days ago, I think it was introduced with #7062
As can be seen here: https://github.com/actualbudget/actual/actions/workflows/docker-edge.yml
Related issue(s)
We're getting this error when running the docker image in the pipeline & locally:
Testing
Built and ran it locally
Checklist