[AI] Remove usage of 'web' file types#7033
Merged
MatissJanis merged 19 commits intomasterfrom Feb 20, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…improved readability and error handling. This includes updates to database opening and closing methods across multiple files, ensuring consistent asynchronous behavior. Additionally, minor adjustments were made to encryption functions to support async operations.
…dability. Updated transaction handling to streamline event expectations and cleanup process.
…ility and error handling. Updated service stopping, encryption, and file upload/download methods to ensure consistent asynchronous behavior across the application.
…t method, enhancing error handling and readability. Update merge tests to utilize async/await for improved clarity in transaction merging expectations.
…elated database operations, enhancing error handling and consistency across file interactions. Updated tests to reflect asynchronous behavior in database operations and file writing.
…void> instead of Proise<void>.
Auto-generated by VRT workflow PR: #6987
…ensuring consistent asynchronous behavior in database operations.
…treamline path handling. Refactor file operations to enhance type safety and consistency across different environments. Add tests for SQLite interactions and ensure proper handling of database transactions.
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MatissJanis
changed the title
✅ Deploy Preview for actualbudget-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for actualbudget-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…prove consistency across methods. Remove deprecated web file handling and enhance encryption functions for better browser compatibility.
Member
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
Contributor
📝 WalkthroughWalkthroughThis pull request consolidates platform-specific module implementations by removing Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (8)
packages/loot-core/src/shared/platform.ts (1)
3-7:navigator.platformis deprecated.
navigator.platformis deprecated and may be removed from browsers in the future. Sinceua-parser-jsis already imported, you could useagent.os.namefor OS detection to future-proof this. Not urgent — just flagging for awareness.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/shared/platform.ts` around lines 3 - 7, Replace deprecated navigator.platform checks in the isWindows and isMac constants by using the ua-parser-js parsed agent OS name: use agent.os.name (the parsed OS string from ua-parser-js) to determine Windows (e.g., name === 'Windows' or contains 'Windows') and macOS (e.g., name === 'Mac OS' or contains 'Mac') instead of navigator.platform; update the definitions of isWindows and isMac to reference agent.os.name so future browser deprecations are avoided.packages/loot-core/src/platform/server/fs/shared.ts (1)
5-5: Removal of type annotation on_setDocumentDirparameter is acceptable given the circular import concern.The previous
T._SetDocumentDirtype was imported from'.'(index.ts), which now re-exports from./shared— creating a circular reference. Dropping the type here avoids that cycle. The@ts-strict-ignoredirective already covers the implicitanyondir.Consider adding an inline type annotation (e.g.,
dir: string) directly to avoid relying solely on@ts-strict-ignorefor this export, without reintroducing the circular import.♻️ Suggested inline type annotation
-export const _setDocumentDir = dir => (documentDir = dir); +export const _setDocumentDir = (dir: string) => (documentDir = dir);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/platform/server/fs/shared.ts` at line 5, The export _setDocumentDir currently drops its parameter type to avoid a circular import; instead add an inline type annotation on the parameter (e.g., change the signature of _setDocumentDir to accept dir: string) so you don't reintroduce the import of T._SetDocumentDir while removing reliance on `@ts-strict-ignore`—update the declaration of _setDocumentDir and ensure the referenced variable documentDir remains compatible with the string type.packages/loot-core/src/server/encryption/encryption-internals.electron.ts (1)
51-66: Address type mismatch between platform-specific key representations increateKeyandimportKey.The Electron implementation returns
Bufferfor therawproperty, while the shared module returnsCryptoKey(WebCrypto). The@ts-expect-errorsuppressions are necessary due to this incompatibility. Consider refactoring to use a platform-agnostic key type (e.g.,CryptoKey | Buffer) in the shared module to eliminate these suppressions, though this may require adjustments to the encryption/decryption functions to handle both types.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/server/encryption/encryption-internals.electron.ts` around lines 51 - 66, The Electron impl of createKey and importKey returns Buffer for the raw key while the shared types expect CryptoKey; remove the ts-expect-error by making the shared key type platform-agnostic (e.g., KeyType = CryptoKey | Buffer) and update all usages: update the shared module's type definitions to export KeyType, change signatures that reference T.createKey/T.importKey to use KeyType, and modify encryption/decryption functions (the functions that accept the key) to handle both Buffer and CryptoKey branches (convert Buffer to the needed format or use WebCrypto when CryptoKey). After those updates, replace the two functions createKey and importKey to return the agreed KeyType and remove the `@ts-expect-error` annotations.packages/loot-core/src/server/db/index.ts (1)
142-155: Add adisposecallback to the LRU cache to free evictedStatementobjects.The
lru-cachepackage (v11.2.5) supports adisposecallback that fires when entries are evicted. SinceStatementobjects from the wasm SQLite module hold native memory, adding a dispose handler will ensure prepared statements are properly freed when removed from the cache:♻️ Dispose callback implementation
-let _queryCache = new LRUCache<string, Statement>({ max: 100 }); +let _queryCache = new LRUCache<string, Statement>({ + max: 100, + dispose: (stmt) => { + try { stmt.free?.(); } catch { /* already freed */ } + }, +});This is a pre-existing concern (the cache already stored prepared statements before this PR), so not blocking.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/server/db/index.ts` around lines 142 - 155, The LRU cache currently holds wasm SQLite Statement objects but never frees them; update the LRUCache construction for _queryCache (and in resetQueryCache) to supply a dispose callback that calls the Statement cleanup (e.g., prepared.free() or stmt.free()) when an entry is evicted, and ensure any existing cache replacement in resetQueryCache triggers disposal of entries (by using the cache's dispose behavior or explicitly freeing remaining statements before replacing _queryCache). Target symbols: _queryCache, cache(sql), resetQueryCache, and the stored Statement instances.packages/loot-core/src/platform/server/fs/index.ts (2)
371-380: Redundant branching — both arms of theifdo the same thing.Lines 375-379: the
if (encoding === 'utf8')andelsebranches both call_readFile(filepath, { encoding })with the same argument. One branch is sufficient.Proposed fix
export async function readFile( filepath: string, encoding: 'binary' | 'utf8' = 'utf8', ) { - if (encoding === 'utf8') { - return _readFile(filepath, { encoding }); - } - return _readFile(filepath, { encoding }); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/platform/server/fs/index.ts` around lines 371 - 380, The readFile function contains redundant branching: both the if (encoding === 'utf8') and the fallback return the same call to _readFile(filepath, { encoding }). Simplify readFile by removing the conditional and directly returning _readFile(filepath, { encoding }) so the function just forwards the filepath and encoding to _readFile; update the readFile signature/usage as needed while keeping the encoding default ('utf8') intact.
200-209: Double-close of file handles on error path.In the
catchblock (lines 201-202), bothtofile.close()andfromfile.close()are called. Thefinallyblock (lines 207-208) calls them again unconditionally. Ifclose()is not idempotent, this will throw on the second call and mask the original error.Proposed fix — remove the close calls from the catch block since finally handles it
} catch (error) { - tofile.close(); - fromfile.close(); await _removeFile(toDbPath); logger.error('Failed to copy database file', error); return false; } finally { tofile.close(); fromfile.close(); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/platform/server/fs/index.ts` around lines 200 - 209, The catch block currently calls tofile.close() and fromfile.close() and then the finally block calls them again, risking a second close throwing and masking the original error; remove the explicit tofile.close() and fromfile.close() calls from the catch block (keep the await _removeFile(toDbPath) and logger.error('Failed to copy database file', error) there) and let the finally block perform the unconditional closes, so only one close path (in finally) runs for the functions handling the copy.packages/loot-core/src/platform/server/sqlite/index.ts (2)
190-215: Null-dereference ifinithasn't been called.
SQLis used directly (e.g.,new SQL.Database(...),SQL.FS.readlink(...)) without the null guard that_getModule()provides. IfopenDatabaseis called beforeinit, this will produce an unhelpfulTypeError: Cannot read properties of null. Consider using_getModule()at the top of the function.Proposed fix
export async function openDatabase(pathOrBuffer?: string | Uint8Array) { + const SQL = _getModule(); let db = null;(This shadows the module-level
SQLwith the non-null return of_getModule().)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/platform/server/sqlite/index.ts` around lines 190 - 215, openDatabase uses the module-level SQL variable (e.g., new SQL.Database, SQL.FS.readlink) which can be null if init wasn't called; replace direct SQL accesses by calling _getModule() at the top of openDatabase to obtain a non-null module instance (shadowing SQL locally) and use that instance for all Database and FS operations (e.g., new module.Database, module.FS.readlink) so openDatabase no longer null-dereferences when init hasn't run.
186-188: ReDoS risk inregexpfrom user-supplied SQL patterns.Static analysis correctly flags that
new RegExp(regex)with variable input can be exploited for catastrophic backtracking. This mirrors the same implementation inindex.electron.ts, so it's a pre-existing concern — but worth noting since SQLREGEXPcan be fed arbitrary patterns from user-constructed queries.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/platform/server/sqlite/index.ts` around lines 186 - 188, The regexp function currently constructs RegExp from untrusted SQL patterns (function regexp) which is vulnerable to ReDoS; replace this direct RegExp usage with a safe approach: either validate and reject/escape user-supplied patterns (limit length and forbids known-backtracking constructs) or switch to a safe regex engine like re2 (import RE2 and instantiate RE2(regex) inside regexp), and wrap compilation/testing in try/catch so invalid/unsafe patterns return 0 instead of crashing; apply the same fix to the mirrored implementation in index.electron.ts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/loot-core/src/platform/server/fs/index.ts`:
- Line 264: Rename the misspelled exported function populateFileHeirarchy to
populateFileHierarchy: update the export declaration (export const
populateFileHeirarchy → export const populateFileHierarchy) and update the
invocation(s) that call populateFileHeirarchy (e.g., the call site where
populateFileHeirarchy() is invoked) to use populateFileHierarchy(), and
search/replace any other references/exports in the file to keep the symbol name
consistent.
- Around line 316-319: The exported function basename currently implements
dirname semantics; rename that implementation to dirname and export it, then add
a proper basename that returns the last path segment (i.e., everything after the
final '/' or the entire string if no '/'). Update internal callers that expect a
parent directory (e.g., _mkdirRecursively(basename(path))) to call dirname(path)
instead, and ensure both functions are exported from this module so Electron and
web behave consistently with Node's path.basename and path.dirname.
In `@packages/loot-core/src/platform/server/sqlite/index.ts`:
- Around line 115-117: The catch block currently calls logger.log(sql) which
omits the log level; update the call in the catch handler (catch (e)) to use the
error level by calling logger.log('error', sql) and also include the caught
error object (e) for full context (e.g., logger.log('error', sql, e)); this
ensures the log is recorded at error severity and includes the exception details
while keeping the existing thrown error behavior.
- Around line 119-122: The non-fetchAll branch leaks prepared statements when
sql is a string because db.prepare(sql) creates stmt which is never freed after
stmt.run(params); update the code handling the non-fetchAll path (the branch
that calls stmt.run(params) and returns { changes: db.getRowsModified() }) to
call stmt.free() after running the statement when the statement was created from
a string (same cleanup used in the fetchAll branch) so the prepared Statement is
finalized and doesn't accumulate.
In `@packages/loot-core/src/shared/platform.ts`:
- Around line 11-15: The OS constant's ternary uses isWindows and isMac but
falls back to 'linux' unconditionally, mismatching the type that includes
'unknown' and misclassifying platforms like iPhone/Android; add an explicit
isLinux boolean (or reuse existing platform detection logic if present) and
change the fallback to return 'unknown' when neither isWindows, isMac nor
isLinux is true so OS can be one of 'windows'|'mac'|'linux'|'unknown' (update
the expression referencing OS, isWindows, isMac, and the new isLinux
accordingly).
In `@packages/loot-core/vitest.config.ts`:
- Around line 22-26: The Vitest config's exclude array is replacing Vitest
defaults and uses an incorrect node_modules pattern; modify the exported
config's exclude property to spread configDefaults.exclude first (e.g.
[...configDefaults.exclude, 'src/platform/server/sqlite/index.test.ts',
'src/platform/server/fs/index.test.ts']) and replace 'node_modules' with the
proper glob '**/node_modules/**'; ensure you import configDefaults from
'vitest/config' if not already present and update the exclude array in the
vitest.config.ts export accordingly.
---
Nitpick comments:
In `@packages/loot-core/src/platform/server/fs/index.ts`:
- Around line 371-380: The readFile function contains redundant branching: both
the if (encoding === 'utf8') and the fallback return the same call to
_readFile(filepath, { encoding }). Simplify readFile by removing the conditional
and directly returning _readFile(filepath, { encoding }) so the function just
forwards the filepath and encoding to _readFile; update the readFile
signature/usage as needed while keeping the encoding default ('utf8') intact.
- Around line 200-209: The catch block currently calls tofile.close() and
fromfile.close() and then the finally block calls them again, risking a second
close throwing and masking the original error; remove the explicit
tofile.close() and fromfile.close() calls from the catch block (keep the await
_removeFile(toDbPath) and logger.error('Failed to copy database file', error)
there) and let the finally block perform the unconditional closes, so only one
close path (in finally) runs for the functions handling the copy.
In `@packages/loot-core/src/platform/server/fs/shared.ts`:
- Line 5: The export _setDocumentDir currently drops its parameter type to avoid
a circular import; instead add an inline type annotation on the parameter (e.g.,
change the signature of _setDocumentDir to accept dir: string) so you don't
reintroduce the import of T._SetDocumentDir while removing reliance on
`@ts-strict-ignore`—update the declaration of _setDocumentDir and ensure the
referenced variable documentDir remains compatible with the string type.
In `@packages/loot-core/src/platform/server/sqlite/index.ts`:
- Around line 190-215: openDatabase uses the module-level SQL variable (e.g.,
new SQL.Database, SQL.FS.readlink) which can be null if init wasn't called;
replace direct SQL accesses by calling _getModule() at the top of openDatabase
to obtain a non-null module instance (shadowing SQL locally) and use that
instance for all Database and FS operations (e.g., new module.Database,
module.FS.readlink) so openDatabase no longer null-dereferences when init hasn't
run.
- Around line 186-188: The regexp function currently constructs RegExp from
untrusted SQL patterns (function regexp) which is vulnerable to ReDoS; replace
this direct RegExp usage with a safe approach: either validate and reject/escape
user-supplied patterns (limit length and forbids known-backtracking constructs)
or switch to a safe regex engine like re2 (import RE2 and instantiate RE2(regex)
inside regexp), and wrap compilation/testing in try/catch so invalid/unsafe
patterns return 0 instead of crashing; apply the same fix to the mirrored
implementation in index.electron.ts.
In `@packages/loot-core/src/server/db/index.ts`:
- Around line 142-155: The LRU cache currently holds wasm SQLite Statement
objects but never frees them; update the LRUCache construction for _queryCache
(and in resetQueryCache) to supply a dispose callback that calls the Statement
cleanup (e.g., prepared.free() or stmt.free()) when an entry is evicted, and
ensure any existing cache replacement in resetQueryCache triggers disposal of
entries (by using the cache's dispose behavior or explicitly freeing remaining
statements before replacing _queryCache). Target symbols: _queryCache,
cache(sql), resetQueryCache, and the stored Statement instances.
In `@packages/loot-core/src/server/encryption/encryption-internals.electron.ts`:
- Around line 51-66: The Electron impl of createKey and importKey returns Buffer
for the raw key while the shared types expect CryptoKey; remove the
ts-expect-error by making the shared key type platform-agnostic (e.g., KeyType =
CryptoKey | Buffer) and update all usages: update the shared module's type
definitions to export KeyType, change signatures that reference
T.createKey/T.importKey to use KeyType, and modify encryption/decryption
functions (the functions that accept the key) to handle both Buffer and
CryptoKey branches (convert Buffer to the needed format or use WebCrypto when
CryptoKey). After those updates, replace the two functions createKey and
importKey to return the agreed KeyType and remove the `@ts-expect-error`
annotations.
In `@packages/loot-core/src/shared/platform.ts`:
- Around line 3-7: Replace deprecated navigator.platform checks in the isWindows
and isMac constants by using the ua-parser-js parsed agent OS name: use
agent.os.name (the parsed OS string from ua-parser-js) to determine Windows
(e.g., name === 'Windows' or contains 'Windows') and macOS (e.g., name === 'Mac
OS' or contains 'Mac') instead of navigator.platform; update the definitions of
isWindows and isMac to reference agent.os.name so future browser deprecations
are avoided.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/loot-core/src/platform/server/fs/index.ts (2)
371-380: Redundant branching — both paths are identical.Lines 375–377 and 379 both call
_readFile(filepath, { encoding })with the exact same arguments, making theifblock a no-op.Suggested simplification
export async function readFile( filepath: string, encoding: 'binary' | 'utf8' = 'utf8', ) { - if (encoding === 'utf8') { - return _readFile(filepath, { encoding }); - } - return _readFile(filepath, { encoding }); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/platform/server/fs/index.ts` around lines 371 - 380, The readFile function contains redundant branching because both branches call _readFile(filepath, { encoding }) with the same args; simplify by removing the if/else and return a single call to _readFile with the encoding parameter. Update the readFile function (referenced by name) to directly return _readFile(filepath, { encoding }) and preserve the signature and default encoding value to maintain behavior.
104-108:String.fromCharCode.applycan throwRangeErroron large files.
Function.prototype.applyspreads the typed array elements as individual arguments. Most engines cap arguments around 65 536, so any file larger than ~128 KB will crash with "Maximum call stack size exceeded" or aRangeError.Pre-existing, but
TextDecoderis the safe replacement:Proposed fix
- if (opts?.encoding === 'utf8' && ArrayBuffer.isView(item.contents)) { - return String.fromCharCode.apply( - null, - new Uint16Array(item.contents.buffer), - ); - } + if (opts?.encoding === 'utf8' && ArrayBuffer.isView(item.contents)) { + return new TextDecoder().decode(item.contents); + }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/loot-core/src/platform/server/fs/index.ts` around lines 104 - 108, The current branch that checks opts?.encoding === 'utf8' and ArrayBuffer.isView(item.contents) uses String.fromCharCode.apply which will throw a RangeError on large buffers; replace that logic with a TextDecoder-based decode of the underlying bytes (use the view's buffer/byteOffset/byteLength to construct a Uint8Array) so large files are decoded safely, keeping the same conditional (opts?.encoding === 'utf8' && ArrayBuffer.isView(item.contents)) and removing the String.fromCharCode.apply call.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/loot-core/src/platform/server/fs/index.ts`:
- Around line 186-209: The catch block in _copySqlFile currently calls
tofile.close() and fromfile.close() redundantly because the finally block also
closes them; remove the close() calls from the catch so cleanup is handled only
in finally (leave the existing tofile.close()/fromfile.close() in the finally
block). Also adjust the cleanup call in the catch: pass the absolute output path
(topath) or otherwise the same path format _removeFile expects instead of
toDbPath (the value returned from pathToId()), so _removeFile receives a correct
absolute path.
---
Duplicate comments:
In `@packages/loot-core/src/platform/server/fs/index.ts`:
- Around line 316-319: The exported function basename currently returns the
directory (dirname) instead of the final path segment; update the basename
implementation (function basename, parameter filepath) to return the last path
component: handle trailing slashes by trimming them, split on '/' and return the
final non-empty segment (or '' for root/empty input); ensure behavior matches
typical basename semantics (e.g., "a/b/c" -> "c", "/a/b/" -> "b").
---
Nitpick comments:
In `@packages/loot-core/src/platform/server/fs/index.ts`:
- Around line 371-380: The readFile function contains redundant branching
because both branches call _readFile(filepath, { encoding }) with the same args;
simplify by removing the if/else and return a single call to _readFile with the
encoding parameter. Update the readFile function (referenced by name) to
directly return _readFile(filepath, { encoding }) and preserve the signature and
default encoding value to maintain behavior.
- Around line 104-108: The current branch that checks opts?.encoding === 'utf8'
and ArrayBuffer.isView(item.contents) uses String.fromCharCode.apply which will
throw a RangeError on large buffers; replace that logic with a TextDecoder-based
decode of the underlying bytes (use the view's buffer/byteOffset/byteLength to
construct a Uint8Array) so large files are decoded safely, keeping the same
conditional (opts?.encoding === 'utf8' && ArrayBuffer.isView(item.contents)) and
removing the String.fromCharCode.apply call.
diepala
pushed a commit
to diepala/actual
that referenced
this pull request
Mar 6, 2026
* [AI] Desktop client, E2E, loot-core, sync-server and tooling updates Co-authored-by: Cursor <cursoragent@cursor.com> * Refactor database handling in various modules to use async/await for improved readability and error handling. This includes updates to database opening and closing methods across multiple files, ensuring consistent asynchronous behavior. Additionally, minor adjustments were made to encryption functions to support async operations. * Refactor sync migration tests to utilize async/await for improved readability. Updated transaction handling to streamline event expectations and cleanup process. * Refactor various functions to utilize async/await for improved readability and error handling. Updated service stopping, encryption, and file upload/download methods to ensure consistent asynchronous behavior across the application. * Refactor BudgetFileSelection component to use async/await for onSelect method, enhancing error handling and readability. Update merge tests to utilize async/await for improved clarity in transaction merging expectations. * Refactor filesystem module to use async/await for init function and related database operations, enhancing error handling and consistency across file interactions. Updated tests to reflect asynchronous behavior in database operations and file writing. * Fix typo in init function declaration to ensure it returns a Promise<void> instead of Proise<void>. * Update VRT screenshots Auto-generated by VRT workflow PR: actualbudget#6987 * Update tests to use async/await for init function in web filesystem, ensuring consistent asynchronous behavior in database operations. * Update VRT screenshot for payees filter test to reflect recent changes * Update filesystem module to remove web-specific implementations and streamline path handling. Refactor file operations to enhance type safety and consistency across different environments. Add tests for SQLite interactions and ensure proper handling of database transactions. * Add release notes for maintenance: Remove usage of 'web' file types * Refactor filesystem module to use type annotations for exports and improve consistency across methods. Remove deprecated web file handling and enhance encryption functions for better browser compatibility. * Trigger CI * Add asyncStorage API file to export Electron index module * Trigger CI * Feedback: typo --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shawalli
added a commit
to shawalli/actual
that referenced
this pull request
Mar 10, 2026
* Typescript: make arithmetic.ts strict (#6801) * Make arithmetic.ts strict TypeScript compliant - Add type definitions for ParserState, Operator, OperatorNode, and AstNode - Add explicit type annotations to all function parameters - Fix null/undefined handling in parsePrimary function - Remove type assertion in makeOperatorParser by using explicit Operator type - Handle null return from currencyToAmount function - All functions now have proper return type annotations * Add test for ignoring leftover characters in evalArithmetic function * Add oxlint rule against direct theme imports; fix Login OpenID button styles (#6796) Co-authored-by: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> * Improve bug report template with better structure and requirements (#6784) * Improve bug report template with better structure and requirements * Fix: Remove empty value fields from textarea inputs in bug report template * Add release notes for PR #6784 * Update 6784.md * Update bug report template to request a screenshot of the import screen along with a redacted file version for better issue resolution. * Update bug report template for import issues Clarified instructions for reporting import issues. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix translation issue #6828 (#6845) * Fix translation issue #6828 * Add release note * [autofix.ci] apply automated fixes * update release number --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Avoid negative zero in budget summary amounts (#6843) * fix: report widget tooltip z-index (#6849) * Fix sync server migrations (#6346) * Fix sync-server migrations to use ESM loader * Add release notes * Apply CodeRabbit suggestions * [autofix.ci] apply automated fixes * Add file extension filter to sync-server migrations import * [autofix.ci] apply automated fixes * Ensure migrations occur synchronously * [autofix.ci] apply automated fixes * Minor cleanup --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * fix(i18n): respect browser preferred languages when supported (#6812) * fix(i18n): respect browser preferred languages when supported Instead of relying on the first browser language, the application now iterates through navigator.languages and selects the first supported locale, with a fallback to English. * chore: add the release notes related file * fix(i18n): check region locales support before falling back to base locale * fix(i18n): make the unit test aligned with the region locales checking * switch to node alpine docker image (#6840) * switch to node alpine image * note * Include scheduled transactions in nYNAB imports (#6844) * Include scheduled transactions in nYNAB imports * Remove logs and restore schedule name from transaction memo * Simplify rule actions * Create schedules with unique names * Set the note rather than append * Update ynab5 demo budget and e2e test * Update findSortUp and findSortDown parameter to be more generic (#6861) * findSortUp and findSortDown is also used for CategoryEntity. Updating type to be more generic. * Generics * Add release notes for PR #6861 * Adjust category to Maintenance based on review feedback (#6865) * Initial plan * Change release notes category to Maintenance Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Use consistent color variables on Budget Page. (#6820) * Change color of budget table scrollbar. * Update budget sidebar to use budget colors. * Update fontWeight for 'Category' to match rest of table * Update to use budget background * Update ExpenseGroup to use budget color * Update IncomeGroup to use budget color * Update SidebarCategory colors Change drag/drop to buttonPrimaryBackground so it will always be visible in any custom theme. Background to budget color. * Update SidebarGroup background to budget color * Update EnvelopeBudgetComponents Add 'budgetNumberNeutral' to cheveronDown in budgeted field instead of using default bare button text incases where bare button is set to normal button text and normal button is inverted. remove mobile color variable for shadow * Update BudgetTotals.tsx Use tableHeaderText for header. * Update BudgetSummary.tsx Use budget colors * Update MonthPicker.tsx change selected months at top from tableBorderHover color to buttonPrimaryBackground. * [autofix.ci] apply automated fixes * Update EnvelopeBudgetComponents.tsx * Update BudgetTotals.tsx revert * Update SidebarCategory.tsx * Update TrackingBudgetComponents to use budget colors * [autofix.ci] apply automated fixes * Update BudgetSummary to use budget colors * Update BudgetTotal.tsx * Update ExpenseProgress.tsx * Update IncomeProgress.tsx * Update Saved.tsx * Use consistent color variables on budget pages. * Update IncomeProgress.tsx * Update ExpenseProgress.tsx * Update VRT screenshots Auto-generated by VRT workflow PR: #6820 * Update EnvelopeBudgetComponents Budget total header to follow current/other month style. * Update EnvelopeBudgetComponents.tsx * [autofix.ci] apply automated fixes * Update EnvelopeBudgetComponents.tsx * Update EnvelopeBudgetComponents.tsx * [autofix.ci] apply automated fixes * Update EnvelopeBudgetComponents.tsx * Revert EnvelopeBudgetComponents.tsx * [autofix.ci] apply automated fixes * Update EnvelopeBudgetComponents.tsx * Update EnvelopeBudgetComponents.tsx * Update EnvelopeBudgetComponents.tsx * Revert again :) EnvelopeBudgetComponents.tsx --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: isConcise state handling for CashFlow report (#6765) * changes token expiry handling to be automatic sign out (#6798) * changes token expiry handling to be automatic sign out * add release notes --------- Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * Remove comma from all instances of month-year strings (#6748) * Remove comma from all instances of month-year strings, e.g., "January 2026" rather than "January, 2026" * Update VRT screenshots Auto-generated by VRT workflow PR: #6748 * All updated calls now include `locale` as an argument * Update dependencies in `useEffect` to include `locale` * Reorganized new import * Remove double colon * Consistent trailing commas * Include locale in other dependency arrays * Reorder imports * Update VRT screenshots Auto-generated by VRT workflow PR: #6748 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * Move redux state to react-query - category states (#5977) * Move redux state to react query - category states * Fix typecheck errors * Fix typecheck errors * Fix typecheck errors * Remove t argument * [autofix.ci] apply automated fixes * Coderabbot suggestion * Code review feedback * Fix type * Coderabbit * Delete useCategoryActions * Fix lint * Use categories from react query cache * Fix typecheck error * Update to use useDeleteCategoryGroupMutation * Coderabbit feedback * Break up useCategoryActions * [autofix.ci] apply automated fixes * Fix typecheck errors * Fix typecheck error * Fix typecheck error * await nested mutations * Await deleteCategory * Rename to sendThrow * Fix lint errors --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Fix react/exhaustive-deps in Modals (#6862) * Fix react/exhaustive-deps in Modals * Add release notes for PR #6862 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix react/exhaustive-deps in PayeeTable (#6863) * Fix react/exhaustive-deps in Modals * Fix react/exhaustive-deps in PayeeTable * Add release notes for PR #6863 * Change category and fix dependency management in PayeeTable Updated category from 'Enhancements' to 'Maintenance' and fixed dependency management in PayeeTable. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix react-hooks/exhaustive-deps in CustomReport (#6867) * Fix react-hooks/exhaustive-deps in CustomReport * Add release notes for PR #6867 * Fix typecheck errors * [autofix.ci] apply automated fixes * Change category to Maintenance and update description * [autofix.ci] apply automated fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Fix react-hooks/exhaustive-deps in ImportTransactionsModal (#6868) * Fix react-hooks/exhaustive-deps in ImportTransactionsModal * [autofix.ci] apply automated fixes * Add release notes for PR #6868 * Update category to Maintenance and fix warnings --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Apply tag colors to YNAB flag tags (#6866) * Apply tag colors to match YNAB flags * Update tag colors to match YNAB, add description on import * Tighten types * Use custom colors * Use Actual palette equivalents for tag colors * Nitpick fixes * Fix nitpick 'fix' * Handle YNAB flag tag conflicts * Handle YNAB flag tag conflicts without creating separate color tags * Simplify * Reorganize * Fix date range calculation in BudgetAnalysisCard (#6875) * fix: corrected date range calculation in BudgetAnalysisCard using calculateTimeRange * add release note * fix: ensure correct date formatting in BudgetAnalysisCard for start and end dates * fix: rename release note file * Add Catppuccin Themes to custom theme catalog (#6857) * Add Catppuccin Themes to theme catalog * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Avoid duplicate category import errors in YNAB5 importer (#6878) * avoid duplicate category import errors Add normalizeError helper function * Add release notes file * Fix react-hooks/exhaustive-deps in DateSelect (#6864) * Fix react-hooks/exhaustive-deps in DateSelect * Add release notes for PR #6864 * Fix remaining suppressions * Change category to Maintenance and fix linting issues Updated category from Enhancements to Maintenance and fixed linting issues related to react-hooks/exhaustive-deps in DateSelect. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add build-electron to tsconfig excludes (#6883) * Add build-electron to tsconfig excludes * Add release notes for PR #6883 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add bank sync option to update dates. (#6850) Signed-off-by: Christian Speich <christian@spei.ch> * Add new theme 'You Need A Dark Mode' to catalog (#6891) * Add new theme 'You Need A Dark Mode' to catalog * Add 'You Need A Dark Mode' theme to catalog * Update the Create Linked Account workflow to prompt for Starting Date and Balance (#6629) * feat: Add optional starting date and balance for bank sync accounts Adds the ability to specify a custom starting date and balance when linking new bank sync accounts in the Select Linked Accounts modal. Addresses: https://discord.com/channels/937901803608096828/1402270361625563186 Changes: - Frontend: Added inline date and amount input fields in the account linking table for new accounts - Redux: Extended link account actions to accept startingDate and startingBalance parameters - Backend: Updated account linking handlers to pass custom values to sync logic - Sync: Modified syncAccount and processBankSyncDownload to use custom starting date/balance for initial sync transactions Features: - Only displays starting options when creating new accounts (not upgrades) - AmountInput with smart sign detection based on account balance (negative for credit cards/loans) - Defaults to 90 days ago for date and 0 for balance - Mobile-responsive with separate AccountCard layout - Works across all sync providers: GoCardless, SimpleFIN, Pluggy.ai The custom starting balance is used directly for the starting balance transaction, and the custom starting date determines both the sync start date and the transaction date for the starting balance entry. * refactor: Extract shared types and components for starting balance inputs - Create CustomStartingSettings type to replace repeated inline type definitions - Extract StartingOptionsInput component to consolidate duplicate UI between mobile/desktop views - Create LinkAccountBasePayload type shared across GoCardless, SimpleFIN, and PluggyAI link functions - Apply same base type pattern to server-side link account handlers This simplifies the code introduced for custom starting date/balance when linking bank accounts. [autofix.ci] apply automated fixes * allow explicit zero values * refactor: add type guard for BankSyncError to remove oxlint-disable - Create isBankSyncError() type guard function with proper type narrowing - Remove oxlint-disable-next-line comment that suppressed the no-explicit-any rule - Add JSDoc comments for both isBankSyncError and handleSyncError functions - Remove redundant type assertion now that type guard narrows correctly * refactor: address code review nitpicks for SelectLinkedAccountsModal - Use locale-aware date formatting instead of toISOString() - Extract isNewAccountOption helper to reduce duplication - Align AccountCardProps type definition pattern with TableRowProps * Add placeholder date/balance for already linked accounts * [autofix.ci] apply automated fixes * Use StartingBalanceInfo only, and add mobile view --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * :art: Storybook docs for block, card, colorpicker, formerror (#6874) * storybook docs for block, card, colorpicker, formerror * release notes * Fix Ctrl+Enter losing amount value when adding transaction (#6911) * Fix Ctrl+Enter losing amount value when adding transaction Fixes #6901 When using Ctrl+Enter to add a transaction immediately after typing in the amount field, the value wasn't being committed before the transaction was saved, resulting in a zero amount. The fix wraps the add-and-close logic in an afterSave() callback to ensure field values are committed before adding the transaction. Added regression tests for both debit and credit fields to verify the fix works correctly. * Add release notes for PR #6911 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * Fix feedback link for budget analysis report experimental flag (#6914) * :electron: Flathub PR to be draft on release (#6910) * make flathub pr draft so that we dont attract attention * release notes * grammar * Points: pay for contributions (#6481) * Add point totals display to all statistics sections in count-points script * Update funding contributors documentation and add release notes for contributor point counting script * Refactor contributor points calculation and enhance PR category determination - Updated point values for PR contributions: reduced points for Features, Enhancements, Bugfix, and Maintenance, and added a new category for Unknown contributions. - Introduced a new function to retrieve the last commit SHA before a specified date to improve accuracy in reading release notes. - Modified the getPRCategoryAndPoints function to accept a monthEnd parameter for better context in point assignment. * Update contributor points values in count-points script to reflect new scoring system * Add new blog post on funding contributors' next steps This post outlines plans to expand the contributor compensation system, including broader rewards for project involvement, targeted donations, and a points-based system for feature work. It emphasizes transparency and community feedback in shaping future funding strategies. * Increase Bugfix points from 2 to 3 * Change points awarded for Features to 2 * Enforce consistent TypeScript type import style (#6805) * Refactor: extract tooltip components and clean up lint suppressions (#6721) * Refactor: extract tooltip components and clean up lint suppressions Extract CustomTooltip components from CrossoverGraph and NetWorthGraph to module level to fix unstable nested components lint warnings. Also consolidate theme file lint rule into oxlintrc.json and add proper typing to styles object. * Add release notes for maintenance updates addressing lint violations * Remove style prop from CustomTooltip to prevent container layout styles from affecting tooltip Co-authored-by: matiss <matiss@mja.lv> * Refactor NetWorthGraph component by extracting TrendTooltip and StackedTooltip into separate functions for improved readability and maintainability. Update tooltip props to include necessary parameters for rendering. Clean up unused code and enhance tooltip styling. * Refactor NetWorthGraph component to streamline tooltip handling - Removed unnecessary prop passing for translation function in TrendTooltip. - Adjusted import statements for better clarity and consistency. - Cleaned up code to enhance readability and maintainability. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * Remove duplication of CrossoverData type (#6928) * Remove duplication of CrossoverData type Move the CrossoverData type definition to crossover-spreadsheet.tsx and import it from the Crossover and CrossoverCard files instead of having duplicate definitions in each file. Signed-off-by: Jonathon Jongsma <jonathon@quotidian.org> * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) --------- Signed-off-by: Jonathon Jongsma <jonathon@quotidian.org> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Add Tag API (#6746) * Add Tag API * Add Tag API tests * Add Release Note for #6746 * Make release note more user-facing * Remove unnecessary type coercion in tagModel.fromExternal Since APITagEntity picks all properties from TagEntity, the types are structurally identical and TypeScript can verify compatibility without manual coercion. Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> --------- Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> * [FIX] Update DesktopLinkedNotes so links stay inline (#6858) * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes so links stay inline * Update TransactionsTable.tsx make sure flexDirection is row. * [autofix.ci] apply automated fixes * Update DesktopLinkedNotes.tsx * Update TransactionsTable.tsx * Update DesktopLinkedNotes.tsx * Update NotesTagFormatter.tsx trial * Update DesktopLinkedNotes.tsx * Update NotesTagFormatter.tsx * Update NotesTagFormatter.tsx * Update DesktopLinkedNotes.tsx * [autofix.ci] apply automated fixes * Update TransactionsTable.tsx * Update DesktopLinkedNotes.tsx Add role for accessibility * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx Revert to original * Update DesktopLinkedNotes.tsx Try to style the bare button to make it work. * [autofix.ci] apply automated fixes * Update DesktopLinkedNotes.tsx Reverting to current master * Update DesktopLinkedNotes.tsx Add nowrap styling. * Update DesktopLinkedNotes.tsx * Update TransactionsTable.tsx * Update TransactionsTable.tsx * [autofix.ci] apply automated fixes * Update DesktopLinkedNotes.tsx * Update TransactionsTable.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * [autofix.ci] apply automated fixes * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * revert TransactionsTable.tsx * Update TransactionsTable.tsx * Update TransactionsTable.tsx * Update TransactionsTable.tsx * Update DesktopLinkedNotes.tsx * Update TransactionsTable.tsx * Update TransactionsTable.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Revert DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * [autofix.ci] apply automated fixes * Update DesktopLinkedNotes.tsx * [autofix.ci] apply automated fixes * Update DesktopLinkedNotes.tsx * Update DesktopLinkedNotes.tsx * [autofix.ci] apply automated fixes * Update DesktopLinkedNotes.tsx * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> * Add butterfly custom theme (#6900) * Added butterfly custom theme * Added release notes * Fix/6885 crash when rule has empty date field (#6905) * Fix crash when rule date field loses focus while empty Fixes #6885 * Remove ts-strict-ignore and fix types in DateSelect * Generate release note 6905 * fix(schedules): prevent past missed schedule dates from being marked as upcoming (#6925) Fixes #6872 * [Goals] fix tracking budget balance carryover for templates (#6922) * fix tracking budget balance carryover for templates * Add release notes for PR #6922 * fix note * fix tests --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * :art: Reorganising Storybook and more component stories (#6924) * reorg of storybook docs and add some new components * releaes notes * Update meta tags for Actual Budget Design System * Increase sidebar item font size from 14px to 16px * Move redux state to react-query - category states [Part 2 - expose react-query states e.g. isPending, isSuccess, etc] (#6882) * Move redux state to react-query - category states [Part 2 - expose react-query states] * Add release notes for PR #6882 * Add default values to useCategories destructuring to prevent undefined crashes (#6884) * Initial plan * Add missing defaults to all useCategories usages Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Fix lint errors * Fix rebase mistake * Change category from Enhancements to Maintenance Migrate state management for category from Redux to React Query and update related hooks and components. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Retrofit useTransactions to use react-query under the hood (#6757) * Retrofit useTransactions to use react-query under the hood * Add release notes for PR #6757 * Update packages/desktop-client/src/transactions/queries.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Disable when there is no query parameter * Fix typecheck errors * Remove space * Update tests * Coderabbit: Add pageSize to query key * Use isPending instead of isFetching * Unexport mockStore * Revert variables * Change category from Enhancements to Maintenance Refactor the useTransactions hook to improve data fetching with react-query. * Fix lint errors * Fix lint errors * Migrate setupTests.js to TypeScript with proper types (#6871) * Initial plan * Rename setupTests.js to setupTests.ts and add proper types Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Extract Size type to avoid duplication Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Add release note for setupTests TypeScript migration Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Rename release note file to match PR number 6871 Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * [autofix.ci] apply automated fixes * Update transactionQueries * Delete setupTests PR release note --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * feat(currency): Add South Korean Won (#6846) * Add South Korean Won * Update currencies.ts * Add release notes * feat(currency): Add Vietnamese Dong (VND) currency (#6902) * feat(currency): add support for vietnamese dong currency * release: add upcoming release note * fix(currency): change the number format for vietnamese currency * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Add refetchOnSync option to useTransactions to refetch when a server sync event is emitted (#6936) * Migrate setupTests.js to TypeScript with proper types (#6871) * Initial plan * Rename setupTests.js to setupTests.ts and add proper types Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Extract Size type to avoid duplication Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Add release note for setupTests TypeScript migration Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Rename release note file to match PR number 6871 Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Delete setupTests PR release note * Add refetchOnSync to useTransactions to refetch when a server sync event is emitted * Add release note for useTransactions refetchOnSync feature (#6937) * Initial plan * Add release note for PR 6936 Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Coderabbit feedback --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * :art: Add remaining component stories to storybook (#6940) * final storybook stories * release notes * spelling mistake * Fix react query cache not being cleared when switching budgets (#6953) * Fix react query cache not being cleared when switching budgets * React does not want to export function from src/index * Release note * Fix mobile budget amount inputs when hide decimal places is enabled (#6945) * Upgrade oxfmt and oxlint, update .oxfmtrc.json import patterns (#6955) Co-authored-by: Cursor <cursoragent@cursor.com> * Retrofit useReports to use react-query under the hood (#6951) * Retrofit useReports to use react-query under the hood * Add release notes for PR #6951 * Update 6951.md * Report mutations --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update `send` function to propagate any errors and fix `catchErrors` to return the error in result when an unknown command/method is sent to the browser server (#6942) * Fix send not returning error when catchErrors option is enabled and an unknown method error is encountered * Add release notes for PR #6942 * Fix send to properly propagate errors from the server * Update release note --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * API Account Object (#6915) * api change * docs * lint * release notes * spelling * [autofix.ci] apply automated fixes * spelling * whoopsie, thanks rabbit --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * feat: add back button to reports pages (#6702) * feat: add back button to reports pages * Update VRT screenshots Auto-generated by VRT workflow PR: #6702 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Rename loot-core/platform/client/fetch to connection to match server-side package (#6943) * Rename loot-core/platform/client/fetch package to connection to match the server side package name. Also to avoid confusion with the native fetch package. * Update connection/init method to not receive any parameter to so browser and default implementation have the same signature * Add release notes for PR #6943 * Fix names * Fix imports --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: show/hide reconciled transactions on mobile (#6896) * feat: show/hide reconciled transactions on mobile Resolves #2969 * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Move redux state to react-query - tags states (#6941) * Move redux state to react-query - tags states * Add release notes for PR #6941 * Cleanup sendThrow * Cleanup * Update import * Fix import --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * docs: add Architecture Decision Records page with bank sync credential ADR (#6965) * docs: add Architecture Decision Records page for controversial decisions Co-authored-by: Cursor <cursoragent@cursor.com> * Add release notes for PR #6965 --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Docs: add Claude Code Pro subscription benefit for core contributors (#6963) * Add Claude Code Pro subscription benefit for core contributors Co-authored-by: Cursor <cursoragent@cursor.com> * Add release notes for PR #6963 --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Agent instructions for commit messages and PR titles (#6964) * [AI] Add mandatory [AI] prefix requirement for commit messages and PR titles Co-authored-by: matiss <matiss@mja.lv> * [autofix.ci] apply automated fixes * Add release notes for PR #6964 --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Move redux state to react-query - account states (#6140) * Fix typecheck errors * Move redux state to react-query - account states * TestProviders * Add release notes for PR #6140 * Fix lint error * Fix TestProviders * Coderabbit feedback * Cleanup * [autofix.ci] apply automated fixes * Fix TestProviders * Fix onbudget and offbudget displaying closed accounts * [skip ci] Change category to Maintenance and update migration text * Replace logger calls in desktop-client to console * Fix lint errors * Clear react query on closing of budget file similar to redux resetApp action * [autofix.ci] apply automated fixes * Remove sendThrow * Code review feedback * [autofix.ci] apply automated fixes * Fix import * Fix import * Coderabbit feedback --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * [AI] lint: convert oxlint warnings to errors (#6970) Co-authored-by: Cursor <cursoragent@cursor.com> * Add filter option for category groups (#6834) * Add filter by category groups * Add tests * Add release notes * [autofix.ci] apply automated fixes * Fix typecheck findings * Fix modal * Address nitpick comment (filterBy) * Fix e2e tests * Make group a subfield of category * Fix test by typing in autocomplete * Replace testId with a11y lookups * Apply new type import style rules * Apply feedback * Improve typing on array reduce, remove manual type coercion --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Fix some low-hanging-fruit `@ts-strict-ignore` (#6969) * Fix low-hanging-fruit `@ts-strict-ignore` * Add release notes * A few more * Include category group in transaction export (#6960) * include category group in transaction export * Apply suggestion from @yzAlvin Co-authored-by: Alvin Zhao <yzalvin@duck.com> --------- Co-authored-by: youngcw <calebyoung94@gmail.com> * Implement missing logic for limit template type (#6690) * core: support limit refill templates * notes: refill templates * core: apply refill limits during runs * core: prioritize refill limits * Patch * Update release note * Fix typecheck * rework. Tests and template notes still need reworked * fix parser syntax * Fix type issue * Fix after rebase, support merging limit+refill * PR feedback --------- Co-authored-by: youngcw <calebyoung94@gmail.com> * :book: Move pluggy.ai doc out of experimental (#6975) * move pluggy out of experimental * remove note * Add release notes for PR #6975 * fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [AI] Update CodeRabbit config for suspect AI generated labels (#6985) Co-authored-by: Cursor <cursoragent@cursor.com> * [AI] Introduce type-aware oxlint and disable no-duplicate-type-constituents rule (#6984) Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ios): restore status bar color on iOS 26.2 (Safari 26) (#6983) * fix(ios): restore status bar color on iOS 26.2 (Safari 26) Safari 26 no longer uses the theme-color meta tag for the status bar and instead derives the tint from the body background. Set body background-color in HTML and sync it with the app theme so the status bar shows purple (or the active theme) instead of white. Fixes #6946 Co-authored-by: Cursor <cursoragent@cursor.com> * [autofix.ci] apply automated fixes * refactor(theme): update useMetaThemeColor to accept theme values directly Modified the useMetaThemeColor hook to accept theme color values instead of predefined keys. Updated FinancesApp and ManagementApp components to utilize the new implementation, ensuring proper theme color handling based on screen width. * [autofix.ci] apply automated fixes * refactor(theme): remove unused body background color in index.html and add tests for useMetaThemeColor hook Deleted the commented-out body background color in index.html to clean up the code. Added comprehensive tests for the useMetaThemeColor hook to ensure proper handling of theme colors, including support for CSS variables and reactivity to theme changes. * refactor(theme): improve getPropertyValueFromVarString function in useMetaThemeColor hook * [autofix.ci] apply automated fixes * Add release notes for PR #6983 --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Address some more low-hanging fruit for ts-strict-ignore (#6992) * Address some more low-hanging fruit for ts-strict-ignore * Add release notes * Fix small issues * Rabbit * Retrofit dashboard hooks to use react-query (#6957) * Retrofit useReports to use react-query under the hood * Add release notes for PR #6951 * Update 6951.md * Report mutations * Fix react query cache not being cleared when switching budgets (#6953) * Fix react query cache not being cleared when switching budgets * React does not want to export function from src/index * Release note * Use react-query is dashboard queries and mutations * Add release notes for PR #6957 * [autofix.ci] apply automated fixes * Fix typecheck errors * Coderabbit feedback * Make error cause optional * Rename useDashboardWidgetCopyMenu and update useDashboardWidget to accept object to prevent need to default id to empty string --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Fix operator precedence grouping for */ and +/- (#6993) * Fix operator precedence grouping for */ and +/- * Add release note for #6993 * Fix exponent associativity and add regression test --------- Co-authored-by: Hadi Ayache <hadiayache@Hadis-Mac-mini.local> * Add Tag API docs (#6979) * Add Tag object type definition for API docs * Add Tags nav entry to API reference sidebar * Add Tags methods and examples to API reference * Add theming to charts and hence allowing custom themes on charts (#6909) * Add theming to charts and hence allowing custom themes on charts * Removing additional color scales for charts. * Fixed return fail over value. * Add reports to command bar (#7002) * Add reports to command bar * Add release notes * Improve category server app and react query mutation error handling (#6958) * Improve category server app and react query mutation error handling * Add release notes for PR #6958 * Fix test * Fix throwing async test Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Do not swallow exceptions when batching messages - propagate instead * Update error type to make 'cause' optional Make 'cause' property optional in error type. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fix redirect to accounts page when no accounts exists (#7007) * Fix redirect to accounts page when no accounts exists * Add release notes for PR #7007 * Use isFetching --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update useAccounts to return react query states (#7009) * Fix redirect to accounts page when no accounts exists * Add release notes for PR #7007 * Use isFetching * Update useAccounts to return react query states (e.g. isPending, isFetching, etc.) * Add release notes for PR #7009 * Delete upcoming-release-notes/7007.md * Change category from Enhancements to Maintenance Refactor `useAccounts` to improve data handling. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Move redux state to react-query - payees states (#6880) * Move redux state to react-query - account states * Fix onbudget and offbudget displaying closed accounts * Move redux state to react-query - payees states * Add release notes for PR #6880 * Replace usage of logger in desktop-client with console * Address feedback on adding default data to usePayees (#6931) * Initial plan * Add default data to usePayees usages using inline destructuring Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Fix imports * Update empty payees list test * Cleanup and simplify AccountEntity definition to fix `satisfies` syntax --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: joel-jeremy <20313680+joel-jeremy@users.noreply.github.com> * Document graph color variables for custom themes (#7011) * Document graph color variables for custom themes Added documentation for graph color variables in custom themes. * [autofix.ci] apply automated fixes * Update custom themes documentation for clarity Clarify the impact of color palettes on custom report widget graphs and format the list of color variables. * Update packages/docs/docs/experimental/custom-themes.md Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * Fix color variable syntax in custom themes documentation Updated color variable syntax for chart colors in documentation. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * :book: start of reports dashboard updates (#6976) * start of reports dashboard updates * spelling * Add release notes for PR #6976 * don't need one of these * consistent naming * bunny fixes * images * image again * extenion * fix * consistent naming * naming * fix * last one * Ill be done with this someday --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ⬆️ mid month dependency bump (#7013) * baseline-browser-mapping (^2.9.14 → ^2.9.19) * minimatch (^10.1.1 → ^10.1.2) * lage (^2.14.15 → ^2.14.17) * react-aria-components (^1.14.0 → ^1.15.1) * @storybook/addon-a11y (^10.2.0 → ^10.2.7) * p-limit (^7.2.0 → ^7.3.0) * better-sqlite3 (^12.5.0 → ^12.6.2) * vitest (^4.0.16 → ^4.0.18) * @storybook/addon-docs (^10.2.0 → ^10.2.7) * @storybook/react-vite (^10.2.0 → ^10.2.7) * eslint-plugin-storybook (^10.2.0 → ^10.2.7) * storybook (^10.2.0 → ^10.2.7) * @codemirror/state (^6.5.3 → ^6.5.4) * @swc/core (^1.15.8 → ^1.15.11) * @tanstack/react-query (^5.90.19 → ^5.90.20) * @vitejs/plugin-basic-ssl (^2.1.3 → ^2.1.4) * @vitejs/plugin-react (^5.1.2 → ^5.1.3) * i18next (^25.7.4 → ^25.8.4) * react-aria (^3.45.0 → ^3.46.0) * react-hotkeys-hook (^5.2.1 → ^5.2.4) * react-i18next (^16.5.1 → ^16.5.4) * sass (^1.97.2 → ^1.97.3) * @easyops-cn/docusaurus-search-local (^0.52.2 → ^0.52.3) * react (^19.2.3 → ^19.2.4) * react-dom (^19.2.3 → ^19.2.4) * component lib peer deps * eslint-vitest-rule-tester (^3.0.1 → ^3.1.0) * lru-cache (^11.2.4 → ^11.2.5) * ua-parser-js (^2.0.7 → ^2.0.9) * cors (^2.8.5 → ^2.8.6) * @babel/core (^7.28.5 → ^7.29.0) * @types/node (^22.19.3 → ^22.19.10) * react (mixed → 19.2.4) * @testing-library/react (16.3.0 → 16.3.2) * react-router (7.12.0 → 7.13.0) * vite-plugin-node-polyfills (^0.24.0 → ^0.25.0) * pluggy-sdk (^0.79.0 → ^0.83.0) * note * [AI] Allow var(--name) in custom theme CSS (no fallbacks) (#7018) Co-authored-by: Cursor <cursoragent@cursor.com> * ⬆️ @playwright/test (1.57.0 → 1.58.2) (#7021) * @playwright/test (1.57.0 → 1.58.2) * note * disable moving nav bar animations * vrt * [AI] lint: await-thenable, no-floating-promises (#6987) * [AI] Desktop client, E2E, loot-core, sync-server and tooling updates Co-authored-by: Cursor <cursoragent@cursor.com> * Refactor database handling in various modules to use async/await for improved readability and error handling. This includes updates to database opening and closing methods across multiple files, ensuring consistent asynchronous behavior. Additionally, minor adjustments were made to encryption functions to support async operations. * Refactor sync migration tests to utilize async/await for improved readability. Updated transaction handling to streamline event expectations and cleanup process. * Refactor various functions to utilize async/await for improved readability and error handling. Updated service stopping, encryption, and file upload/download methods to ensure consistent asynchronous behavior across the application. * Refactor BudgetFileSelection component to use async/await for onSelect method, enhancing error handling and readability. Update merge tests to utilize async/await for improved clarity in transaction merging expectations. * Refactor filesystem module to use async/await for init function and related database operations, enhancing error handling and consistency across file interactions. Updated tests to reflect asynchronous behavior in database operations and file writing. * Fix typo in init function declaration to ensure it returns a Promise<void> instead of Proise<void>. * Update VRT screenshots Auto-generated by VRT workflow PR: #6987 * Update tests to use async/await for init function in web filesystem, ensuring consistent asynchronous behavior in database operations. * Update VRT screenshot for payees filter test to reflect recent changes * [AI] Fix no-floating-promises lint error in desktop-electron Wrapped queuedClientWinLogs.map() with Promise.all and void operator to properly handle the array of promises for executing queued logs. Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> * Refactor promise handling in global and sync event handlers * Update VRT screenshots Auto-generated by VRT workflow PR: #6987 --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> * Bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 (#7020) * Bump @isaacs/brace-expansion from 5.0.0 to 5.0.1 Bumps @isaacs/brace-expansion from 5.0.0 to 5.0.1. --- updated-dependencies: - dependency-name: "@isaacs/brace-expansion" dependency-version: 5.0.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * note --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> * feat(currency): Add Dominican Peso (DOP) currency (#7028) * feat(currency): Add Dominican Peso (DOP) currency * Add release notes * ⬆️ recharts (3.4.0 → 3.7.1) (#7022) * recharts (3.4.1 -> 3.7.0) * Cell & activeShape deprecation * note * fix textAnchor * remove Cell in BarGraph * Fix Net Worth Calculations (#6968) * fix: computed priorPeriodNetWorth and use it as a baseline for net worth calculations * add release notes * correct spelling * Update VRT screenshots Auto-generated by VRT workflow PR: #6968 * Update VRT screenshots Auto-generated by VRT workflow PR: #6968 * Update VRT screenshots Auto-generated by VRT workflow PR: #6968 * Update VRT screenshots Auto-generated by VRT workflow PR: #6968 * Update VRT screenshots Auto-generated by VRT workflow PR: #6968 * note --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: youngcw <calebyoung94@gmail.com> * Set inital focus on category when covering overspending (#7012) * Set inital focus on category when covering overspending * Fixup: Make sure that the amount is set * Unused import * Fix bug where typing an amount and pressing enter uses previous value --------- Co-authored-by: Dagur Ammendrup <dagurp@vivaldi.com> * 🎨 High Contrast Light theme for Actual (#7032) * Update customThemeCatalog.json * [autofix.ci] apply automated fixes * Create 7032.md 🎨 High contrast light theme. * Update customThemeCatalog.json * Update 7032.md --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Require authentication for SimpleFIN and Pluggy.ai endpoints (#7034) * Add authentication middleware to SimpleFIN and Pluggy.ai endpoints Protect /simplefin/* and /pluggyai/* routes with validateSessionMiddleware so only authenticated users can access bank account and transaction data. Co-authored-by: Cursor <cursoragent@cursor.com> * Release notes --------- Co-authored-by: Cursor <cursoragent@cursor.com> * Enhance PR template with structured sections (#6989) * Enhance PR template with description, type of change, and checklist sections Co-authored-by: Cursor <cursoragent@cursor.com> * Update PR template to streamline instructions for writing release notes * Remove unnecessary lines from the PR template to streamline instructions for writing release notes * Add release notes for PR #6989 * Update category in release notes Changed category from Enhancements to Maintenance. * Update PULL_REQUEST_TEMPLATE.md * Update AGENTS.md and PULL_REQUEST_TEMPLATE.md to clarify PR submission guidelines * Update 6989.md --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add ACTUAL_USER_CREATION_MODE documentation to oauth-auth.md (#6935) * Add ACTUAL_USER_CREATION_MODE documentation to oauth-auth.md * [autofix.ci] apply automated fixes * add note that first external auth user is admin and owner Added details about admin permissions and server ownership for users authenticating with OpenID/OAuth2. * improve ACTUAL_USER_CREATION_MODE environment documentation clarify warning about server owner * [autofix.ci] apply automated fixes * move first user admin warning to "after setup" section of OIDC documentation --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Add tooltip to imported payee in rule result window (#7031) * Add tooltip to imported payee column in rule result window The imported payee column in SimpleTransactionsTable was missing a title attribute, so truncated text had no tooltip on hover. Other columns (category, account, notes) already pass title for this purpose. Fixes #7003 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add release notes for #7031 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Your Name <your-email@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * Hide selected accounts in the mobile filter (#7030) When filtering for accounts in the mobile view of reports, hide the already selected accounts. * Prevent single-slash paths from being parsed as filepaths (#6966) * fix: prevent single-slash paths from being parsed as filepaths * add release notes * [autofix.ci] apply automated fixes * test: add tests related to filepath * additonal test from coderabbit --------- Co-authored-by: Pratik Silwal <pratiksilwal@Pratiks-MacBook-Air.local> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * [AI] Remove usage of 'web' file types (#7033) * [AI] Desktop client, E2E, loot-core, sync-server and tooling updates Co-authored-by: Cursor <cursoragent@cursor.com> * Refactor database handling in various modules to use async/await for improved readability and error handling. This includes updates to database opening and closing methods across multiple files, ensuring consistent asynchronous behavior. Additionally, minor adjustments were made to encryption functions to support async operations. * Refactor sync migration tests to utilize async/await for improved readability. Updated transaction handling to streamline event expectations and cleanup process. * Refactor various functions to utilize async/await for improved readability and error handling. Updated service stopping, encryption, and file upload/download methods to ensure consistent asynchronous behavior across the application. * Refactor BudgetFileSelection component to use async/await for onSelect method, enhancing error handling and readability. Update merge tests to utilize async/await for improved clarity in transaction merging expectations. * Refactor filesystem module to use async/await for init function and related database operations, enhancing error handling and consistency across file interactions. Updated tests to reflect asynchronous behavior in database operations and file writing. * Fix typo in init function declaration to ensure it returns a Promise<void> instead of Proise<void>. * Update VRT screenshots Auto-generated by VRT workflow PR: #6987 * Update tests to use async/await for init function in web filesystem, ensuring consistent asynchronous behavior in database operations. * Update VRT screenshot for payees filter test to reflect recent changes * Update filesystem module to remove web-specific implementations and streamline path handling. Refactor file operations to enhance type safety and consistency across different environments. Add tests for SQLite interactions and ensure proper handling of database transactions. * Add release notes for maintenance: Remove usage of 'web' file types * Refactor filesystem module to use type annotations for exports and improve consistency across methods. Remove deprecated web file handling and enhance encryption functions for better browser compatibility. * Trigger CI * Add asyncStorage API file to export Electron index module * Trigger CI * Feedback: typo --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [AI] Enforce file access authorization on sync API endpoints (#7040) * [AI] Enforce file access authorization on sync API endpoints Co-authored-by: Cursor <cursoragent@cursor.com> * Refactor file deletion authorization to return error message as text * Refactor file upload validation to improve error handling * Add tests to allow admin users to retrieve encryption keys and sync files for other users - Implemented a test for admin access to retrieve encryption keys for another user's file in the /user-get-key endpoint. - Added a test for admin users to sync another user's file in the /sync endpoint, ensuring proper response and headers. These changes enhance the authorization checks for admin actions on user files. * Refactor file cleanup in tests to use onTestFinished for better error handling * Enhance admin capabilities in file management tests * Add migration to backfill file owners with admin ID * Enhance file access authorization in sync API * Update migration to backfill file owners with admin ID to ensure consistent ordering in the query * Refactor access control tests for file downloads in sync API * Add test for non-owner file download access via user_access in sync API This test verifies that users with appropriate access can download files owned by others, utilizing the requireFileAccess logic and UserService.countUserAccess. It ensures correct response headers and content delivery for shared files. * Refactor file cleanup in upload and download tests to utilize onTestFinished for improved error handling This update consolidates file cleanup logic in the test suite, ensuring that temporary files are removed after each test execution. The changes enhance the reliability of tests by consistently managing file state across various scenarios. --------- Co-authored-by: Cursor <cursoragent@cursor.com> * Add limit/refill automation types (#6692) * Add limit/refill automation components * Add release note * Fix typecheck * Rabbit PR feedback * Review * [AI] Add per-package tsconfigs and typescript-strict-plugin for typecheck (#7019) * [AI] Add per-package tsconfigs and typescript-strict-plugin for typecheck Co-authored-by: Cursor <cursoragent@cursor.com> * Update TypeScript configuration across multiple packages to correct plugin path key from "path" to "paths" and add reference to process-worker typings in index.electron.ts. * Remove reference to process-worker typings in index.electron.ts and add new process-worker typings file for global Process augmentation. * Refactor TypeScript build configurations across multiple packages by removing tsconfig.dist.json files and updating build scripts to use default TypeScript compilation. Adjusted compiler options to target ES2021 and enable declaration generation. * Update TypeScript configuration in api package to refine include and exclude patterns for better file management. * Update build script in api package to ensure migration SQL files are copied to the correct directory by creating the destination folder if it doesn't exist. * Update TypeScript configurations in crdt and desktop-electron packages to refine include and exclude patterns for improved file management. * Update TypeScript dependencies across multiple packages to include typescript-strict-plugin for enhanced type checking and maintain consistency in package.json files. --------- Co-authored-by: Cursor <cursoragent@cursor.com> * v26.2.1: critical security fix for simplefin, pluggy and multi-user (#7043) * Add release notes for version 26.2.1, including critical security fixes for SimpleFin, Pluggy, and multi-user setups. Remove outdated upcoming release notes for related bugfixes. * Add release notes for PR #7043 * Delete upcoming-release-notes/7043.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [AI] Bump version to 26.2.1 (#7052) Co-authored-by: Cursor <cursoragent@cursor.com> * Rename theme 'Okabe Ito' to 'Color-blind (dark)' (#7058) * Rename theme 'Okabe Ito' to 'Color-blind (dark)' * Rename 'Okabe Ito' theme to 'Color-blind (dark)' * Fix capitalization in theme name for consistency * Validate file IDs for correctness (#7067) * Validate file IDs for correctness * Add release notes * 🐞 Midnight theme: Change menuAutoCompleteTextHover color - Fixes #7029 (#7048) * Change menuAutoCompleteTextHover color to green400 * Change menuAutoCompleteTextHover color to green400 in Midnight theme. Change menuAutoCompleteTextHover color to green400 in Midnight theme. * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * :bug: Fix file path on windows (#7076) * fix file path on windows * file path in migrations * release notes * [AI] Fix API build output path (dist/index.js instead of dist/api/index.js) (#7084) * [AI] Fix API build output path (dist/index.js instead of dist/api/index.js) - Set rootDir in packages/api/tsconfig.json so output is under dist/ not dist/api/ - Remove loot-core pegjs.ts from include; add local typings/pegjs.d.ts - Use mkdir -p in build:migrations for idempotent build - Exclude **/@types/** so declaration output does not conflict with input Made-with: Cursor * Update TypeScript configuration in api package to refine exclude patterns * Mobile rules item alignment (#7081) * [AI] Fix mobile rules list items to be full width and left-aligned - Override Button's default justifyContent/alignItems centering in ActionableGridListItem to use flex-start alignment - Add width: 100% to RulesListItem's SpaceBetween to fill the item width Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> * Add release notes for PR #7081 * Change category from Enhancements to Bugfix --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [AI] Remove 'suspect ai generated' label and associated workflow (#7087) * Initial plan * [AI] Remove 'suspect ai generated' label and associated workflow Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> * [AI] Remove 'suspect ai generated' label from coderabbit config Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> * Add release notes for PR #7087 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [Cursor] Development environment setup (#7088) * [AI] Add Cursor Cloud specific instructions to AGENTS.md Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> * [autofix.ci] apply automated fixes * Add release notes for PR #7088 * [AI] Fix Node.js minimum version requirement in AGENTS.md (#7089) * [AI] Fix outdated Node.js version requirement in Build Failures section Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> * [AI] Add test budget tip to Cursor Cloud instructions Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Matiss Janis Aboltins <MatissJanis@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> * [AI] Github action for unfreezing PRs (#7094) * [AI] Add GitHub Action to add PR to Merge Freeze unblocked list when unfreeze label is added Made-with: Cursor * Rename 7093.md to 7094.md * Add concurrency control to unfreeze job in merge-freeze-unfreeze workflow - Introduced concurrency settings to prevent overlapping executions of the unfreeze job based on labels. - Updated error handling to abort the process if fetching the current merge freeze status fails, ensuring unblocked PRs are not overwritten. * Refactor Merge Freeze workflow to simplify PR unblocking process - Updated the workflow to directly post the PR to the unblocked list without fetching the current freeze status. - Improved error handling by ensuring the access token is set before proceeding with the API call. * Revert "feat(currency): Add Vietnamese Dong (VND) currency" (#7100) * Revert "feat(currency): Add Vietnamese Dong (VND) currency (#6902)" This reverts commit 7fa9fa900b3b590078ba88ac70377c25769782a7. * Add release notes for PR #7100 * Delete 7100.md --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix bugfix categorisation in contributor points counting script (#7103) * s/bugfix/bugfixes * note * add alias functionality * note update * [AI] Make merge-freeze-unfreeze workflow work on fork PRs (#7104) * [AI] Make merge-freeze-unfreeze workflow work on fork PRs via pull_request_target Made-with: Cursor * Add release notes for the "unfreeze" workflow functionality in fork PRs * Add empty permissions block to unfreeze job in merge-freeze-unfreeze workflow * 🔖 (26.3.0) (#7097) * 🔖 (26.3.0) * Remove used release notes * Add release notes for PR #7097 * Remove used release notes * Remove used release notes * Add release notes for version 26.3.0 * Add new terms to spelling expectation list * Fix spelling and capitalization in release notes Corrected spelling of 'reorganisation' to 'reorganization' and updated 'coderabbit' to 'CodeRabbit' for consistency. * Update patterns.txt to allowlist 'CodeRabbit' Add 'CodeRabbit' to allowlist of proper nouns. * Clarify chart theming support in release notes Updated the release notes to specify bar/pie chart theming support and added details about theme variables for customization. * Remove 'CodeRabbit' from spelling expectations * Refactor release notes and improve formatting Reorganize release notes for clarity and update content. * Create 2026-03-02-release-26-3-0.md * Change release date to 2026-03-02 Updated the release date for version 26.3.0. * Update release notes for version 26.3.0 --------- Co-authored-by: jfdoming <9922514+jfdoming@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Julian Dominguez-Schatz <julian.dominguezschatz@gmail.com> --------- Signed-off-by: Christian Speich <christian@spei.ch> Signed-off-by: Jonathon Jongsma <jonathon@quotidian.org> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Matiss Janis Aboltins <matiss@mja.lv> Co-authored-by: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nam <nam.tr.ha02@gmail.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Stephen Brown II <Stephen.Brown2@gmail.com> Co-authored-by: Matthias Benaets <89214559+MatthiasBenaets@users.noreply.github.com> Co-authored-by: Joshua Granick <jgranick@users.noreply.github.com> Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk> Co-authored-by: Adam <github.jodes@aleeas.com> Co-authored-by: Joel Jeremy Marquez <joeljeremy.marquez@gm…
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting rid of the ".web.ts" file types. The defaults should be the "web" variants. And then ".api.ts" and "*.electron.ts" should be the platform-specific overrides (which I would eventually also like to kill, but that's another story).
It might seem like this is a lot of changes, but it is mostly just
mv packages/loot-core/src/shared/platform.web.ts packages/loot-core/src/shared/platform.tstype of change with a few types patched.Split off from: #6809
Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/shared/platform.tshome/runner/work/actual/actual/packages/loot-core/src/shared/platform.web.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
loot-core
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/platform/server/fs/index.tshome/runner/work/actual/actual/packages/loot-core/src/platform/server/sqlite/index.tshome/runner/work/actual/actual/packages/loot-core/src/platform/server/fs/path-join.tshome/runner/work/actual/actual/packages/loot-core/src/server/encryption/encryption-internals.tshome/runner/work/actual/actual/packages/loot-core/src/shared/platform.tshome/runner/work/actual/actual/packages/loot-core/src/platform/server/fs/index.web.tshome/runner/work/actual/actual/packages/loot-core/src/platform/server/sqlite/index.web.tshome/runner/work/actual/actual/packages/loot-core/src/platform/server/fs/path-join.web.tshome/runner/work/actual/actual/packages/loot-core/src/server/encryption/encryption-internals.web.tshome/runner/work/actual/actual/packages/loot-core/src/shared/platform.web.tsView detailed bundle breakdown
Added
Removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
api
Total
Changeset
node_modules/ua-parser-js/src/main/ua-parser.mjssrc/server/encryption/encryption-internals.electron.tssrc/shared/platform.tssrc/mocks/random.tssrc/platform/server/fs/index.electron.tssrc/platform/server/fs/index.api.tssrc/server/budgetfiles/app.tssrc/server/sheet.tssrc/server/encryption/encryption-internals.tssrc/shared/platform.electron.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged