Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions packages/sync-server/src/migrations.js

This file was deleted.

52 changes: 52 additions & 0 deletions packages/sync-server/src/migrations.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import path, { dirname } from 'node:path';
import { fileURLToPath } from 'node:url';
import { readdir } from 'node:fs/promises';

import migrate from 'migrate';

import { config } from './load-config.js';

Check warning on line 7 in packages/sync-server/src/migrations.ts

View workflow job for this annotation

GitHub Actions / autofix

Unexpected use of file extension "js" for "./load-config.js"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

export async function run(direction: 'up' | 'down' = 'up'): Promise<void> {
console.log(
`Checking if there are any migrations to run for direction "${direction}"...`,
);

const __dirname = dirname(fileURLToPath(import.meta.url)); // this directory
const migrationsDir = path.join(__dirname, '../migrations');

try {
// Load all script files in the migrations directory
const files = await readdir(migrationsDir);
const migrationsModules: { [key: string]: { up: Function, down: Function } } = {};

Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
await Promise.all(
files
.sort()
.map(async (f) => {
migrationsModules[f] = await import(path.join(migrationsDir, f));
})
);
Comment thread
jgranick marked this conversation as resolved.
Outdated

return new Promise<void>((resolve, reject) => {
migrate.load(

Check failure on line 31 in packages/sync-server/src/migrations.ts

View workflow job for this annotation

GitHub Actions / typecheck

Property 'load' does not exist on type '(title: string, up: (next: NextFunction) => void, down: (next: NextFunction) => void) => void'.
{
stateStore: `${path.join(config.get('dataDir'), '.migrate')}${config.get('mode') === 'test' ? '-test' : ''}`,
migrations: migrationsModules,
Comment thread
cursor[bot] marked this conversation as resolved.
},
(err, set) => {
if (err) return reject(err);

set[direction](err => {
if (err) return reject(err);

console.log('Migrations: DONE');
resolve();
});
}
);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
});
} catch (err) {
console.error('Error during migration process:', err);
throw err;
}
}
6 changes: 6 additions & 0 deletions upcoming-release-notes/6346.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [jgranick]
---

Fix sync-server migrations to use ESM loader
Loading