revise modal margin #2714
revise modal margin #2714
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
@uniqueeest Please add a release note. You can refer to https://actualbudget.org/docs/contributing/#writing-good-release-notes. |
|
@joel-jeremy I already add a release note. Is that how you write it? |
|
Your release note needs to match the PR number. Thats why its failing the test |
|
Thank you @youngcw ! |
| @@ -65,7 +65,7 @@ export function CreateEncryptionKeyModal({ | |||
| <Modal | |||
| {...modalProps} | |||
| style={{ | |||
| padding: '0 10px', | |||
| padding: 10, | |||
There was a problem hiding this comment.
I think Modal has a default padding so we can remove this one.
| @@ -61,7 +61,7 @@ export function FixEncryptionKeyModal({ | |||
| hasExistingKey ? 'Unable to decrypt file' : 'This file is encrypted' | |||
| } | |||
| style={{ | |||
| padding: '0 10px', | |||
| padding: 10, | |||
There was a problem hiding this comment.
@joel-jeremy Corrections are complete.
trafico-bot
bot
added
✨ Merged
As I checked the modals, there were no parts that needed to be corrected except for the two modals found in the issue. So, I just proceeded to revise the two modals to the requested margin.