Saved Filters Page #1122
Saved Filters Page #1122
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
👋 Overall: great stuff! The ability to save filters and re-use them is long overdue. However, I don't think we should build a new page for managing them. One of the design principles of Actual is - simplicity first with progressive feature discovery for more advanced customers. Take for example the notes field - it is shown in various parts of the product when you hover a specific element. It is not shown by default. Only if you provide notes and save - only then the icon is always visible. Similarly for saved filters: I think instead of reserving prime real-estate for them, we could build them more as a discoverable feature. So for example: you add some filters to the transaction page. At that point a "save" button appears. Clicking that maybe opens a modal where you type in the name of the filter. If you want to edit or delete a filter - select it in the dropdown to apply it to the current state. And then do any modifications you want. Or click "delete". What do you think about that? |
I get it. Your suggestion makes sense. It could be pretty visible (eg. a purple button pops up next to the "collapse transactions" button) or it could be hidden under the "export" option in the "..." menu. That said, I'm happy doing it either way, just need concensus from the community on how we want to implement it. My plan was to do both - allowing creation and editing of saved filters on the accounts page via modals but also having a place to see them all in one place and manage them as needed. Personally I like the option to be able to manage the filters in a single place without having to deal with hidden menus and the like. If having the page link hidden in the "more" drop-down sidebar is considered to be too visible we could also look at burying it in the settings page somewhere. |
|
I like the idea of saving a current filter vs building one then using it after. I do worry that people could easily create multiple filters that do the same thing with different names if its not easy/obvious to look at what they do and modify them. |
I plan to implement a block/warning for any filters that fall into this category (eg. duplicating existing saved filter conditions exactly). |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Fixed the margins, I think I've fixed all bugs so far. Let me know if there's any others. Only thing that's outstanding right now is the ctrl+z after create/update/delete actions. The undo works but it doesn't change the rendered window which is confusing. The only thing I've managed to do is to refresh the entire page after an undo, not sure this is what's wanted. So my choices are refresh after successful undo action or disable the undo actions. Thoughts? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok, so I see three blocking issues now:
We're nearly there.. :) |
Fixed
Okay, the delete undo works fine with no refresh (this is the most neccessary IMO). The create undo is not neccessary because you can just delete the newly created filter via the UI. Same with rename, instead of undoing it you can just rename it back to previous name. Is that an acceptable UX for this feature and those acitons?
This now pulls the conditionsOp from the saved filter on the Reports Header in all report pages. |
Bundle Stats - desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats - loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Perfect! Thank you so much for this and for your patience with all the feedback!
I'll allow @j-f1 to review too since he's been quite involved, but on my end this looks good to go.
trafico-bot
bot
added
✨ Merged
|
Woo!! Thanks all. |
|
Looks great in the preview! Cant wait for the full release. |
trafico-bot
bot
added
🔍 Ready for Review
and removed
✨ Merged
Adding background update to cleared/uncleared boxes on accounts page. This is needed due to Accounts page background change in previous PR (#1122)
* master: (34 commits) chore: add types to `crdt` package (actualbudget#1076) Fix layout of the management app with the demo bar in place (actualbudget#1267) ♻️ (select) removing 2x usages of the Select component (actualbudget#1259) Fix transaction list scrolling behavior (actualbudget#1260) 🐛 fix link-schedule option in transaction table (actualbudget#1250) cleared/uncleared background update (actualbudget#1265) Fix calculation of how many table rows to render (actualbudget#1262) ♻️ moving more components out of common.tsx (actualbudget#1257) ♻️ moving some components from common.tsx to separate files (actualbudget#1248) 🐛 fix toggling of balances in all-accounts view (actualbudget#1252) 🐛 (mobile) reduce the size of account cards (actualbudget#1247) Fix electron export issue (actualbudget#1242) Saved Filters Page (actualbudget#1122) 🔧 cancel previous CI runs if a new push is made (actualbudget#1251) .gitattributes Check line endings for tsx files (actualbudget#1246) Fix importing transfers from YNAB4/5 (actualbudget#1224) Auto-close the local/nordigen picker modal after creating an account (actualbudget#1219) Run “Handle completed feature requests” in pull_request_target (actualbudget#1243) Add electron options to bug-report.yml (actualbudget#1239) Add onClick handlers to the schedule and transaction icons in the transaction list (actualbudget#1228) ...
Adding background update to cleared/uncleared boxes on accounts page. This is needed due to Accounts page background change in previous PR (actualbudget#1122)
Hey all, this is still under construction. Just wanted to share my progress and get any feedback as I go so as to not go down any wrong roads.
DONE:
TODO/Bugs: