Fix sqlx_todo CI checks #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
since this adds sqlx back to the workspace, i'd ask that you make clippy happy while we're here :) otherwise, this looks great |
Contributor
Author
|
My bad, forgot about that. All good now |
JohnTitor
approved these changes
Mar 3, 2021
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
We still have a mention to postgresql on README (Line 3), it should be replaced as well. Otherwise LGTM 👍
Contributor
Author
|
nice catch, good to go now :) |
Member
|
We've encountered bheisler/TinyTemplate#17, let's just ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the example to use sqlite and adds sqlite3 to the CI.
Closes #412