-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate with updated actix-{codec, utils} #1634
Conversation
aeccb0d
to
1a13e5d
Compare
1932fd9
to
33640c3
Compare
33640c3
to
77ee808
Compare
Codecov Report
@@ Coverage Diff @@
## master #1634 +/- ##
==========================================
- Coverage 53.22% 53.17% -0.06%
==========================================
Files 126 127 +1
Lines 11796 11809 +13
==========================================
+ Hits 6279 6280 +1
- Misses 5517 5529 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for working on it <3
@JohnTitor i could do with this one being merged first and getting non-beta releases out so we can use them in this PR. |
77ee808
to
89d3125
Compare
PR Type
Bug Fix / Refactor
PR Checklist
Check your PR fulfills the following:
Overview
Integrates with beta releases of
actix-codec
/actix-utils
.This implementation was made much easier thanks to most places already having an Unpin bound on types. Some traits were changed to receive Pins. One or two Unpin bounds were added. Otherwise no logic or control flow changes were made.
If this PR is approved I think we should move to release non-beta versions of codec and utils before merging this.