Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate with updated actix-{codec, utils} #1634

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Aug 16, 2020

PR Type

Bug Fix / Refactor

PR Checklist

Check your PR fulfills the following:

  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt

Overview

Integrates with beta releases of actix-codec / actix-utils.

This implementation was made much easier thanks to most places already having an Unpin bound on types. Some traits were changed to receive Pins. One or two Unpin bounds were added. Otherwise no logic or control flow changes were made.

If this PR is approved I think we should move to release non-beta versions of codec and utils before merging this.

@JohnTitor JohnTitor mentioned this pull request Aug 18, 2020
15 tasks
@robjtede robjtede changed the title WIP: integrate with master branch actix-{codec, utils} integrate with master branch actix-{codec, utils} Aug 18, 2020
@robjtede robjtede force-pushed the dep/actix-codec branch 4 times, most recently from 1932fd9 to 33640c3 Compare August 19, 2020 23:53
@robjtede robjtede marked this pull request as ready for review August 19, 2020 23:54
@robjtede robjtede requested review from a team August 19, 2020 23:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #1634 into master will decrease coverage by 0.05%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1634      +/-   ##
==========================================
- Coverage   53.22%   53.17%   -0.06%     
==========================================
  Files         126      127       +1     
  Lines       11796    11809      +13     
==========================================
+ Hits         6279     6280       +1     
- Misses       5517     5529      +12     
Impacted Files Coverage Δ
actix-http/src/client/connection.rs 10.95% <0.00%> (-0.31%) ⬇️
actix-http/src/error.rs 32.23% <ø> (ø)
actix-http/src/h1/client.rs 64.36% <ø> (ø)
actix-http/src/h1/codec.rs 65.27% <ø> (ø)
actix-http/src/h1/service.rs 48.87% <0.00%> (-0.38%) ⬇️
actix-http/src/h1/utils.rs 0.00% <0.00%> (ø)
actix-http/src/ws/codec.rs 0.00% <ø> (ø)
actix-http/src/ws/dispatcher.rs 0.00% <0.00%> (ø)
awc/src/connect.rs 15.25% <0.00%> (ø)
awc/src/ws.rs 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d86a6...89d3125. Read the comment docs.

@robjtede robjtede added A-http project: actix-http A-awc project: awc B-semver-patch labels Aug 20, 2020
@robjtede robjtede changed the title integrate with master branch actix-{codec, utils} integrate with updated actix-{codec, utils} Aug 20, 2020
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working on it <3

@robjtede
Copy link
Member Author

@JohnTitor i could do with this one being merged first and getting non-beta releases out so we can use them in this PR.

actix/actix-net#184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-awc project: awc A-http project: actix-http B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants