Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare actix-server-config release #54

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Prepare actix-server-config release #54

merged 2 commits into from
Oct 4, 2019

Conversation

JohnTitor
Copy link
Member

No description provided.

@JohnTitor
Copy link
Member Author

JohnTitor commented Oct 3, 2019 •
edited
Loading

@fafhrd91 Agh, the CI is failed. What should we do? Just merge and publish ignoring CI?

@JohnTitor JohnTitor force-pushed the bump-up-server-config branch from e1bdaab to 33ccb8b Compare October 3, 2019 22:02
@JohnTitor
Copy link
Member Author

JohnTitor commented Oct 3, 2019 •
edited
Loading

Ah, it may be able to be resolved by the latest commit.

@JohnTitor
Copy link
Member Author

@fafhrd91 Could we merge this? I want to confirm it is correct.

@fafhrd91 fafhrd91 merged commit 2667850 into actix:master Oct 4, 2019
@JohnTitor JohnTitor deleted the bump-up-server-config branch October 4, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fafhrd91 fafhrd91 fafhrd91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnTitor @fafhrd91