Skip to content

feat: add "append-items" input#134

Open
scottschreckengaust wants to merge 18 commits intoactions:mainfrom
scottschreckengaust:main
Open

feat: add "append-items" input#134
scottschreckengaust wants to merge 18 commits intoactions:mainfrom
scottschreckengaust:main

Conversation

@scottschreckengaust
Copy link

Closes #129

Allows adding additional items. Specifically dot (hidden) files and folders.

@scottschreckengaust scottschreckengaust requested a review from a team as a code owner December 16, 2025 05:51
@scottschreckengaust
Copy link
Author

This will allow .well-known/ or other files.

@scottschreckengaust
Copy link
Author

Hi @actions/pages folks, let me know if there is something you would like me to consider. Here is a link to the test-hosted-runners.yml in the fork from this PR https://github.com/scottschreckengaust/upload-pages-artifact/actions/runs/20257944177

image

@scottschreckengaust
Copy link
Author

Let me know @yoannchaudet , @TooManyBees , @YiMysty , or others if there is anything left to do.

@scottschreckengaust
Copy link
Author

@TooManyBees can you help approve the awaiting workflow? I've run on the fork with success #134 (comment)

jonchurch added a commit to jonchurch/upload-pages-artifact that referenced this pull request Jan 30, 2026
# The Problem

Hidden files and directories (e.g. `.well-known`) are unconditionally excluded from the tar archive. There is no way to include them. (actions#129)

# The Solution

Add an `include-hidden-files` input (default `false`) that skips the `--exclude=.[^/]*` pattern when set to `true`. `.git` and `.github` are always excluded regardless. Test coverage added for the new option.

I think this is the right approach rather than actions#134. Keep the default behavior safe, and give a sane option to users who know what they're doing. It was safe enough for upload-artifact, it should be safe enough here.

# Context

`actions/upload-artifact` introduced hidden file exclusion and a corresponding `include-hidden-files` option in [v4.4.0](https://github.com/actions/upload-artifact/releases/tag/v4.4.0). This action adopted the same exclusion behavior in its tar step but never added the equivalent option. This PR closes that gap.

The only sane workaround without this option is to drop this action, manually create the tar, and hand it to `upload-artifact` directly. See [expressjs/expressjs.com#2173](expressjs/expressjs.com#2173) for an example.
| `name` | `false` | `github-pages` | Artifact name |
| `path` | `true` | `_site/` | Path of the directory containing the static assets |
| `retention-days` | `false` | `1` | Duration after which artifact will expire in days |
| `append` | `false` | `` | Append files and folders |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `append` | `false` | `` | Append files and folders |
| `append-items` | `false` | `` | Append files and folders |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow publishing of hidden/dot-prefixed files again

2 participants