feat: add "append-items" input#134
Open
scottschreckengaust wants to merge 18 commits intoactions:mainfrom
Open
feat: add "append-items" input#134scottschreckengaust wants to merge 18 commits intoactions:mainfrom
scottschreckengaust wants to merge 18 commits intoactions:mainfrom
Conversation
Added new artifact handling and comparison steps in the workflow.
Clarify comment about creating hidden files or folders.
Added 'append' input option to the action configuration to allow appending files and directories to the archive.
Updated the workflow to include copying the .well-known directory and modified some step names for clarity.
Removed 'exclude-pattern' input and adjusted table.
Refactor artifact handling and add new upload/download steps for appended artifacts.
Author
|
This will allow |
Author
|
Hi @actions/pages folks, let me know if there is something you would like me to consider. Here is a link to the
|
Author
|
Let me know @yoannchaudet , @TooManyBees , @YiMysty , or others if there is anything left to do. |
Author
|
@TooManyBees can you help approve the awaiting workflow? I've run on the fork with success #134 (comment) |
jonchurch
added a commit
to jonchurch/upload-pages-artifact
that referenced
this pull request
Jan 30, 2026
# The Problem Hidden files and directories (e.g. `.well-known`) are unconditionally excluded from the tar archive. There is no way to include them. (actions#129) # The Solution Add an `include-hidden-files` input (default `false`) that skips the `--exclude=.[^/]*` pattern when set to `true`. `.git` and `.github` are always excluded regardless. Test coverage added for the new option. I think this is the right approach rather than actions#134. Keep the default behavior safe, and give a sane option to users who know what they're doing. It was safe enough for upload-artifact, it should be safe enough here. # Context `actions/upload-artifact` introduced hidden file exclusion and a corresponding `include-hidden-files` option in [v4.4.0](https://github.com/actions/upload-artifact/releases/tag/v4.4.0). This action adopted the same exclusion behavior in its tar step but never added the equivalent option. This PR closes that gap. The only sane workaround without this option is to drop this action, manually create the tar, and hand it to `upload-artifact` directly. See [expressjs/expressjs.com#2173](expressjs/expressjs.com#2173) for an example.
jonchurch
reviewed
Jan 30, 2026
| | `name` | `false` | `github-pages` | Artifact name | | ||
| | `path` | `true` | `_site/` | Path of the directory containing the static assets | | ||
| | `retention-days` | `false` | `1` | Duration after which artifact will expire in days | | ||
| | `append` | `false` | `` | Append files and folders | |
There was a problem hiding this comment.
Suggested change
| | `append` | `false` | `` | Append files and folders | | |
| | `append-items` | `false` | `` | Append files and folders | |
jmooring
added a commit
to jmooring/hosting-github-pages
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #129
Allows adding additional items. Specifically dot (hidden) files and folders.